-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jbl/1020721 preserve order in attachmentsdirectory #68
Merged
ptahmose
merged 13 commits into
ZEISS:main
from
ptahmose:jbl/1020721-preserve_order_in_attachmentsdirectory
Oct 20, 2023
Merged
Jbl/1020721 preserve order in attachmentsdirectory #68
ptahmose
merged 13 commits into
ZEISS:main
from
ptahmose:jbl/1020721-preserve_order_in_attachmentsdirectory
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 63.90% 63.98% +0.08%
==========================================
Files 75 75
Lines 10117 10085 -32
==========================================
- Hits 6465 6453 -12
+ Misses 3652 3632 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chriwiz
suggested changes
Oct 19, 2023
chriwiz
approved these changes
Oct 20, 2023
ptahmose
deleted the
jbl/1020721-preserve_order_in_attachmentsdirectory
branch
November 3, 2023 22:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The order of the items in the attachment-directory used to be undefined (when writing a CZI with libCZI). As far as I can tell, this is fine and the order is not relevant by any means (as per file-format). However, it turned out, that some applications made (unjustified!) assumptions about this order.
With the changes in this PR, the order in the attachments-directory will retain the order in which they were added. This allows to work around the flaw in other applications.
Type of change
How Has This Been Tested?
locally
Checklist: