Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for NadHat #2

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Updates for NadHat #2

wants to merge 9 commits into from

Conversation

sdoubey
Copy link

@sdoubey sdoubey commented Aug 12, 2018

The goal of these updates is to support NadHat card

I had to add "SIMCOM_Ltd_SIMCOM_SIM800C" configuration and update configurator to load properties file from classpath OR modem folder

I had to fix date parsing for incoming SMS because i got this error, java.time.format.DateTimeParseException: Text '18/08/11,22:36:21+0000' could not be parsed, unparsed text found at index 20, so i had to change yy/MM/dd,HH:mm:ssx to yy/MM/dd,HH:mm:ssX, to support both formats

I had to handle response for SMS larger than 160 characters, when i tried i got this response from CMGSText command:
[+CDS: 6,178,"+33XXXXXXX",145,"18/08/12,00:54:21+08","18/08/12,00:54:21+08",0<R><N><R><N><R><N>+CMGS: 179<R><N><R><N>]
but you are waiting for something like that:
[<R><N>+CMGS: 181<R><N><R><N>OK<R><N>]
so i changed matcher.matches to matcher.find, it's more permissive and does the job

Fix Configurator properties misspelling
Update configurator to look into modem folder for configuration
Add SIMCOM SIM800C configuration (NadHAT)
Add support for CMSGSText response with +CDS (+160 chars messages)
Fix inbound message date parse error
@ZZerog
Copy link
Owner

ZZerog commented Aug 13, 2018

Great job sir.

I do some tests and merge as soon as possible. The NadHat card look very interesting.

Thanks for the contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants