Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate secret share 283 #2

Merged
merged 13 commits into from
Apr 28, 2023
Merged

Generate secret share 283 #2

merged 13 commits into from
Apr 28, 2023

Conversation

natalieesk
Copy link
Contributor

This closes #283 in Frost repo.

conradoplg
conradoplg approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@conradoplg conradoplg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh I managed to approve the wrong PR, I'm still looking at this one, sorry!

conradoplg
conradoplg approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

I left a bunch of comments but most of them are me thinking out loud, we can make most adjustments in the next demo, I'll leave them up to you

src/inputs.rs Show resolved Hide resolved
src/tests/inputs_tests.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love these tests though, we could move/copy them to frost-core in order to test keygen_with_dealer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created an issue here ZcashFoundation/frost#328

src/main.rs Outdated Show resolved Hide resolved
src/trusted_dealer_keygen.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@natalieesk
Sort participants by identifier (#283)
b584b60 
Improve error handling
Add tests for output
hex encode outputs
@natalieesk
Fix clippy errors (#283)
7738d10
conradoplg
conradoplg approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't mark discussions as solved I think because I don't have write permission in this repo 😅 But everything looks good!

src/trusted_dealer_keygen.rs Outdated Show resolved Hide resolved
@natalieesk
Copy link
Contributor Author

Accept input for trusted_dealer_keygen and return public keys and secret shares

@natalieesk natalieesk closed this Apr 28, 2023
@natalieesk natalieesk reopened this Apr 28, 2023
@natalieesk natalieesk merged commit 15100a2 into main Apr 28, 2023
@natalieesk natalieesk deleted the generate_secret_share_283 branch April 28, 2023 08:30
@mpguerra mpguerra linked an issue May 8, 2023 that may be closed by this pull request
Epic: Demo for Trusted Dealer key share generation ZcashFoundation/frost#238
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradoplg conradoplg conradoplg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate trusted dealer keygen output in CLI demo Epic: Demo for Trusted Dealer key share generation
2 participants
@natalieesk @conradoplg