Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make server act as "aggregator" #265

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Make server act as "aggregator" #265

merged 3 commits into from
Aug 14, 2024

Conversation

conradoplg
Copy link
Contributor

@conradoplg conradoplg commented Jul 18, 2024

Closes #251

Basically:

  • This moves the SessionState from the Server to the Coordinator, with some modifications
  • This removes most functions from the state, adding a new send and receive instead

I ended up doing some refactorings to make the implementation simpler. I should've split that into another PR, sorry!

  • I added a ProcessedArgs struct to the Coordinator which is created from a Args, and does all the handling related to reading inputs files or stdin, etc.
  • I added support for specifying multiple messages and randomizers in the arguments, but this is still not used by the rest of the code. Tracked in Server cleanups #266

@conradoplg conradoplg mentioned this pull request Jul 18, 2024
@mpguerra mpguerra linked an issue Jul 19, 2024 that may be closed by this pull request
Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little typo, otherwise all great

@conradoplg conradoplg merged commit 21a1531 into main Aug 14, 2024
5 checks passed
@conradoplg conradoplg deleted the change-architecture branch August 14, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the Coordinator act as "aggregator" instead of the server
3 participants