Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details to README (#339) #3

Merged
merged 5 commits into from
May 23, 2023
Merged

Add details to README (#339) #3

merged 5 commits into from
May 23, 2023

Conversation

natalieesk
Copy link
Contributor

Adds content to README
Creates Makefile commands

This closes #339

Create Makefile commands
@natalieesk natalieesk requested a review from mpguerra May 2, 2023 15:19
Copy link
Contributor

@mpguerra mpguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I would just add some more details about exactly how to build and run the demo.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks! I think it just needs addressing Pili's comments.

README.md Outdated Show resolved Hide resolved
@mpguerra mpguerra linked an issue May 8, 2023 that may be closed by this pull request
6 tasks
Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixes look good, but I noticed some other issues, sorry for not noticing them in the first pass.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Conrado Gouvea <conradoplg@gmail.com>
@natalieesk
Copy link
Contributor Author

The fixes look good, but I noticed some other issues, sorry for not noticing them in the first pass.

I added in more things based on the suggestions, so this wasn't there the first time round :-)

Co-authored-by: Conrado Gouvea <conradoplg@gmail.com>
@conradoplg
Copy link
Contributor

Looks good to me, waiting for @mpguerra 's approval

@natalieesk natalieesk merged commit a59ca79 into main May 23, 2023
@natalieesk natalieesk deleted the update_readme_339 branch May 23, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build README Epic: Demo for Trusted Dealer key share generation
3 participants