Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add frost-client {init,login,export,import,contacts} #308

Merged
merged 8 commits into from
Oct 2, 2024
Merged

add frost-client {init,login,export,import,contacts} #308

merged 8 commits into from
Oct 2, 2024

Conversation

conradoplg
Copy link
Contributor

Closes #305

@conradoplg conradoplg mentioned this pull request Sep 13, 2024
Merged
natalieesk
natalieesk reviewed Sep 19, 2024
View reviewed changes
README.md Show resolved Hide resolved
natalieesk
natalieesk reviewed Sep 19, 2024
View reviewed changes
frost-client/README.md Outdated Show resolved Hide resolved
conradoplg
conradoplg commented Sep 19, 2024
View reviewed changes
Copy link
Contributor Author

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed comments, thanks!

I think we may want to split the config file into two, one of the private and other for the public part. But we can leave that for later.

frost-client/src/init.rs Show resolved Hide resolved
README.md Show resolved Hide resolved
frost-client/README.md Outdated Show resolved Hide resolved
natalieesk
natalieesk approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I think we could possibly have more test coverage but that could be part of a different PR if we decide it's needed

@conradoplg conradoplg merged commit 52972f7 into main Oct 2, 2024
5 checks passed
@conradoplg conradoplg deleted the frost-client branch October 2, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalieesk natalieesk natalieesk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add contact management functions
2 participants
@conradoplg @natalieesk