-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add frost-secp256k1-tr crate (BIP340/BIP341) #584
Open
zebra-lucky
wants to merge
22
commits into
ZcashFoundation:main
Choose a base branch
from
zebra-lucky:add-secp256k1-tr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Feb 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b380fd5 - Browse repository at this point
Copy the full SHA b380fd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab6b0d0 - Browse repository at this point
Copy the full SHA ab6b0d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8204166 - Browse repository at this point
Copy the full SHA 8204166View commit details -
Configuration menu - View commit details
-
Copy full SHA for a307130 - Browse repository at this point
Copy the full SHA a307130View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d8be7c - Browse repository at this point
Copy the full SHA 6d8be7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20da59a - Browse repository at this point
Copy the full SHA 20da59aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00cdfe5 - Browse repository at this point
Copy the full SHA 00cdfe5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdc8fb4 - Browse repository at this point
Copy the full SHA bdc8fb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a66b9a2 - Browse repository at this point
Copy the full SHA a66b9a2View commit details -
Refactor Ciphersuite taproot methods for universal applicability (#2)
The taproot compatibility methods added to Ciphersuite were very specific to taproot. I renamed them, and tidied up their usage to remove unnecessary if/else branches. This should make them applicable to any ciphersuite which needs to modify such internal processes of the FROST algorithm. This change should be a pure refactor with no logical changes.
Configuration menu - View commit details
-
Copy full SHA for 142556f - Browse repository at this point
Copy the full SHA 142556fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ed163f - Browse repository at this point
Copy the full SHA 0ed163fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c63a3ca - Browse repository at this point
Copy the full SHA c63a3caView commit details
Commits on Mar 5, 2024
-
encapsulate BIP341 tapscript commitment in new SigningTarget type
I added the SigningTarget type, which encapsulates both the message to be signed, and also the tapscript merkle root which the signature should commit to. This allows a FROST group to dynamically select what taproot tweak they would like to commit their signatures to, and to optionally elect not to commit to any tweak at all if desired.
Configuration menu - View commit details
-
Copy full SHA for e5b3f5d - Browse repository at this point
Copy the full SHA e5b3f5dView commit details -
add effective_key method to VerifyingKey
This method allows the group to export their tweaked VerifyingKey, so 3rd parties can verify their signatures without learning the taproot tweak.
Configuration menu - View commit details
-
Copy full SHA for 155dfa6 - Browse repository at this point
Copy the full SHA 155dfa6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1268f5c - Browse repository at this point
Copy the full SHA 1268f5cView commit details
Commits on Mar 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1c085ba - Browse repository at this point
Copy the full SHA 1c085baView commit details
Commits on Mar 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c1b8663 - Browse repository at this point
Copy the full SHA c1b8663View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f52646 - Browse repository at this point
Copy the full SHA 8f52646View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d2d683 - Browse repository at this point
Copy the full SHA 5d2d683View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20c2c98 - Browse repository at this point
Copy the full SHA 20c2c98View commit details
Commits on Apr 26, 2024
-
ensure taproot signatures always use even nonce points
BIP340 signatures are usually represented with x-only (even parity) nonce points. As a step towards normalizing this for the frost-secp256k1-tr crate, we should ensure all Signature struct instances always use the effective nonce point, including the DKG proof-of-knowledge.
Configuration menu - View commit details
-
Copy full SHA for 15688ab - Browse repository at this point
Copy the full SHA 15688abView commit details -
serialize taproot signatures as 64 bytes with x-only nonce
BIP340 signatures are supposed to be serialized as a 64-byte array: 32 bytes for the x-only nonce point 'R', and 32 bytes for the signature component 's'. This commit customizes the frost-secp256k1-tr crate so that signatures are serialized with x-only nonces, omitting the leading parity byte.
Configuration menu - View commit details
-
Copy full SHA for d580241 - Browse repository at this point
Copy the full SHA d580241View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.