Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frost-core): fix dead_code warning #748

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

StackOverflowExcept1on
Copy link
Contributor

This PR fixes dead_code warning. I get this error when reusing frost-core in roast-core.

$ cargo clippy --release -p frost-core --no-default-features -F internals

    Checking frost-core v2.0.0-rc.0 (/tmp/frost/frost-core)
warning: function `detect_cheater` is never used
   --> frost-core/src/lib.rs:637:4
    |
637 | fn detect_cheater<C: Ciphersuite>(
    |    ^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

@StackOverflowExcept1on
Copy link
Contributor Author

@conradoplg

@mergify mergify bot merged commit cef4217 into ZcashFoundation:main Oct 8, 2024
17 checks passed
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.45%. Comparing base (5f4ac6e) to head (5cf2646).
Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
- Coverage   82.18%   81.45%   -0.73%     
==========================================
  Files          31       34       +3     
  Lines        3188     3289     +101     
==========================================
+ Hits         2620     2679      +59     
- Misses        568      610      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants