Provide a Rustier wrapper for zcash_script #171
+432
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ZcashFoundation/zebra#8751 integrates this with zebrad, and shouldn’t be merged until we know that that relationship is working (which it is currently not). |
7 tasks
sellout
force-pushed
the
wrap-bindgen
branch
3 times, most recently
from
707fc0b
to
3c353bd
Compare
Have lib.rs re-export them, but make room for the upcoming Rust implementation.
sellout
force-pushed
the
wrap-bindgen
branch
2 times, most recently
from
b9e0ea0
to
92d9ceb
Compare
This adds a `Script` trait that exposes slightly Rustier types in order to have a common interface for the existing C++ implementation as well as the upcoming Rust implementation (and a third instance that runs both and checks that the Rust result matches the C++ one). The module structure (interpreter.rs, zcash_script.rs) and locations of definitions are intended to mirror the structure of the C++ code, especially as we get the Rust implementation in place, for easier comparison. That organization is very likely to change once everything has been checked.
nuttycom
reviewed
Aug 28, 2024
nuttycom
reviewed
Aug 28, 2024
nuttycom
reviewed
Aug 28, 2024
arya2
reviewed
Aug 29, 2024
arya2
reviewed
Aug 29, 2024
|
The changes in ZcashFoundation/zebra#8751 now work correctly with this, so we’re good for final review. |
nuttycom
reviewed
Aug 30, 2024
arya2
reviewed
Aug 30, 2024
conradoplg
reviewed
Sep 4, 2024
conradoplg
reviewed
Sep 4, 2024
sellout
force-pushed
the
wrap-bindgen
branch
from
b4ad098
to
eca9469
Compare
This should fix the Windows build.
conradoplg
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
Scripttrait that exposes slightly Rustier types in order to have a common interface for the existing C++ implementation as well as the upcoming Rust implementation (and a third instance that runs both and checks that the Rust result matches the C++ one).