Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZO-6181: sync updates from 'merkl' OpenAPI spec #139

Merged
merged 3 commits into from
Sep 9, 2024
Merged

ZO-6181: sync updates from 'merkl' OpenAPI spec #139

merged 3 commits into from
Sep 9, 2024

Conversation

kabbeck
Copy link
Contributor

@kabbeck kabbeck commented Sep 5, 2024

Consult corrections in merkl https://github.com/ZeitOnline/merkl/pull/387

Copy link
Contributor

@witsch witsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also erstmal: das sieht soweit gut aus! 👍

Abgesehen davon passt es thematisch vielleicht nicht ganz zu 100% (aber so ~90 ja schon 😊), aber wir sollten bzw. könnten hier sinnvollerweise wahrscheinlich gleich auch noch die Anpassungen aus https://github.com/ZeitOnline/merkl/pull/394 mit übernehmen. Siehe dazu auch das Update im Ticket

 ef8321f897314b207558056c36a1f796e95a9591
@kabbeck kabbeck requested a review from witsch September 9, 2024 13:19
This also adds an "operation id" for `/merkl/categories`.

Refs: ZO-6181
@witsch witsch changed the title ZO-6181: Pass corrections from Merkl OpenAPI spec ZO-6181: sync differences with 'merkl' OpenAPI spec Sep 9, 2024
@witsch witsch changed the title ZO-6181: sync differences with 'merkl' OpenAPI spec ZO-6181: sync updates from 'merkl' OpenAPI spec Sep 9, 2024
@witsch witsch merged commit 44a3370 into main Sep 9, 2024
1 check passed
@witsch witsch deleted the ZO-6181 branch September 9, 2024 13:58
witsch added a commit that referenced this pull request Sep 20, 2024
It should be accessible for anonymous users as well.

Refs: ZO-4493, #136, #139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants