Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generating wrong e value when the message bytes start with "00" byte #36

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix generating wrong e value when the message bytes start with "00" byte #36

wants to merge 6 commits into from

Commits on Feb 20, 2020

  1. Fix generating wrong e value when the message bytes start with "00" b… 

    …yte.

The sha256 hash function which is used in schnorr signature generation receives inputs as BigInt value. But the BigInt value eliminate head bytes if it is zero. So that, the output of hash function was wrong.
This commit changes the message into BigInt array for each byte of the message.

fix ZenGo-X#35
    @rantan
    rantan committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    55d9376 View commit details
    Browse the repository at this point in the history

  2. Fix generating wrong e value when the message bytes start with "00" b… 

    …yte for zilliqa schnorr.
    @rantan
    rantan committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    3e9161d View commit details
    Browse the repository at this point in the history

  3. Make it to compute e without converting through BigInt

    @rantan
    rantan committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    2c512ab View commit details
    Browse the repository at this point in the history

  4. Make the unit test for compute_e check with concrete value and moved … 

    …to independent file for to share among bitcoin_schnorr and zilliqa_schnorr.

Essentialy how to compute e value is depends on each specification of platforms, but current implemented specification is same. For now it can be shared.
    @rantan
    rantan committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    dda62d9 View commit details
    Browse the repository at this point in the history

  5. fmt

    @rantan
    rantan committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    6c4b661 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2020

  1. Move compute_e into each protocol files. 

    Because this function should be changed to adapt for each specification.
    @rantan
    rantan committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    4f00076 View commit details
    Browse the repository at this point in the history