Skip to content

Commit

Permalink
ci(releases): fix release workflow, was throwing error “cannot create…
Browse files Browse the repository at this point in the history
… release from non-tag”
  • Loading branch information
Zeratoxx committed Mar 2, 2024
1 parent 6310c2b commit 0cbc710
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/bump-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,5 @@ jobs:
uses: ./.github/workflows/publish-release.yml
needs: bump-version
with:
version: ${{ needs.bump-version.outputs.new-tag }}
tag: ${{ needs.bump-version.outputs.new-tag }}
commit: ${{ inputs.commit_sha }}
2 changes: 1 addition & 1 deletion .github/workflows/latest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ jobs:
needs: cleanup-of-dev-release
uses: ./.github/workflows/publish-release.yml
with:
version: ${{ needs.cleanup-of-dev-release.outputs.dev-version }}
tag: ${{ needs.cleanup-of-dev-release.outputs.dev-version }}
11 changes: 7 additions & 4 deletions .github/workflows/publish-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Publish release
on:
workflow_call:
inputs:
version:
tag:
description: 'Version of the bundle'
required: true
type: string
Expand All @@ -25,15 +25,15 @@ jobs:
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
commit_sha: ${{ inputs.commit }}
custom_tag: ${{ inputs.version }}
custom_tag: ${{ inputs.tag }}
create_annotated_tag: true
tag_prefix: ''

bundle:
name: Bundle version ${{ inputs.version }}
name: Bundle version ${{ inputs.tag }}
uses: ./.github/workflows/bundle.yml
with:
version: ${{ inputs.version }}
version: ${{ inputs.tag }}

publish-release:
runs-on: ubuntu-22.04
Expand All @@ -44,6 +44,9 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
with:
ref: refs/tags/${{ github.event.inputs.tag }}
fetch-tags: true

- name: Download bundle artifact
id: download-artifact
Expand Down

0 comments on commit 0cbc710

Please sign in to comment.