Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Marker Improvements #4046

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Arch-Shaman
Copy link
Contributor

@Arch-Shaman Arch-Shaman commented Aug 16, 2020

Adds a delay (5s) between each unit's ping. This fixes the ping spam on los edge.
Removes pings after 10s (for mobiles only, structures will not be removed).

Adds a delay (5s) between each unit's ping. This fixes the ping spam on los edge.
Removes pings after 10s.
@GoogleFrog
Copy link
Contributor

Won't the removal remove other markers and make gaps in drawings?

Technically the 5s delay is unitID hax and it will still spam for armies of spotted units. How about a distance based frequency limit?

@Arch-Shaman
Copy link
Contributor Author

Arch-Shaman commented Aug 17, 2020

Yes it will unfortunately remove placer markers and screw with drawings. However the benefit is that we can de-clutter a mass of labels when big scythe or Athena armies uncloak. I think this benefit outweighs the drawback, though if there was a way to remove local pings that would be great.

Mostly this is an improvement in big team games where mass decloaks aren't uncommon. With a distance modifier, i still think labels from widgets should self remove after some time because the information will eventually be irrelevant and over time this may decrease visibility of the map (the current stable of the widget is notoriously bad with athena clouds on the edge of los!)

I take it you want to store the uncloak position and frame of this position then check on decloak how far it was from it? Perhaps an ordered table of coordinates followed by a ping like " 12 scythes spotted" on next frame?
Or perhaps something else in mind? I'm open for suggestion.

@GoogleFrog
Copy link
Contributor

Grouping things together sounds ideal. I primarily want to avoid adding unitID hax - tracking information about hidden units.

@Arch-Shaman Arch-Shaman marked this pull request as draft September 6, 2020 12:01
@sprunk
Copy link
Member

sprunk commented Jul 9, 2023

Looks stale, is anything going to happen?

@GoogleFrog
Copy link
Contributor

It looks ok but is still a draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants