Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore Odin liftoff sound in fog-safe manner #5070

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Anarchid
Copy link
Member

No description provided.

Comment on lines 89 to 91
StopSpin(turbineTop, y_axis, 0.5);
StopSpin(turbineLeft, y_axis, 0.5);
StopSpin(turbineRight, y_axis, 0.5);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't look sound related and there is no corresponding Spin

@GoogleFrog
Copy link
Contributor

GoogleFrog commented Jan 13, 2024

Has this been tested? It just sounds like a brief click to me. Odin already makes a noise when it receives an order, so this is redundant for the order-giver, and it just seems like noise to anyone else. Sounds are used to tell people that something happened, and I see no value in telling people that Odin took off. Perhaps something like this is good for ambience, but I think we at least would need someone designing the overall audio landscape and designating bits of it for ambience for that to work. I don't think we're going to end up anywhere good ambience-wise by attaching sounds to things piecemeal. When I heard this in the wild I thought my speakers were broken or a sound was clipping. It has a piercing pitch.

@Anarchid
Copy link
Member Author

The sound was originally tested when Eclipse was added. It's supposed to sound like a gas burner being turned on, which does include a bit of clicking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants