Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert health bars #5398

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

amnykon
Copy link
Contributor

@amnykon amnykon commented Dec 13, 2024

sorry in advanced for the large PR.
may be easier to look at each commit separately

  1. I removed the water tank, as archer has not used it in a long time.
  2. Chagned barDrawer.AddBar to barDrawer.AddPercentBar and barDrawer.AddDurationBar
    The new AddXbar functions primarily have 2 simple arguments. Had to add a 3rd to percent due to the color of Health
    To reduce the number of parameters, messages and colors names needed to match, and to make this clearer, reordered them to match as well.
    DE and TR translations were missing speed and heat translation.
    DE's was added (proved by NRHD) TR's was left blank.
  3. added the invert options using the same naming as messages and colors.

@GoogleFrog
Copy link
Contributor

GoogleFrog commented Dec 14, 2024

I'd like invert option in a subpath, as they spam the menu a bit.

@sprunk
Copy link
Member

sprunk commented Dec 15, 2024

Perhaps just a single 3-way radiobutton for inversion?

(o) default
( ) some healthbars are inverted so they are all 100% = good, 0% = bad (like health)
( ) some healthbars are inverted so they are all 100% = bad, 0% = good (like emp)

@amnykon
Copy link
Contributor Author

amnykon commented Dec 15, 2024

I prefer the sub menu. It's more configurable. A future feature may be menu actions that sets the inversion options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants