Payment Request/Invoice: Convert expiration

[shivam-Purohit]

Description

Relates to issue: #2025

Invoices was return in seconds from most backends including eclair and spark. Convert the seconds to date object before returning.

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (c-lightning-REST)
• LndHub
• [DEPRECATED] Core Lightning (Spark)
• [DEPRECATED] Eclair

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[shivam-Purohit]

@kaloudis am I on the right path? i am currently getting an linting error

/home/vboxuser/Desktop/block_chain/zeus/backends/Spark.ts

  197:38  error  Replace `new·Date().getTime()·+·inv.expires_at·*·1000` with `⏎························new·Date().getTime()·+·inv.expires_at·*·1000⏎····················`  prettier/prettier

It returns the same code style. Should i create a new method for that or something?

[kaloudis]

Run npm run prettier-write

…

On Wed, Apr 10, 2024 at 11:09 AM, Shivam Purohit ***@***.***(mailto:On Wed, Apr 10, 2024 at 11:09 AM, Shivam Purohit <<a href=)> wrote: ***@***.***(https://github.com/kaloudis) am I on the right path? i am currently getting an linting error /home/vboxuser/Desktop/block_chain/zeus/backends/Spark.ts 197:38 error Replace `new·Date().getTime()·+·inv.expires_at·*·1000` with `⏎························new·Date().getTime()·+·inv.expires_at·*·1000⏎····················` prettier/prettier It returns the same code style — Reply to this email directly, [view it on GitHub](#2120 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAOKUXO4GF22DH47XW32LXLY4VI2RAVCNFSM6AAAAABGAULABSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBXHAYTKMBWGU). You are receiving this because you were mentioned.Message ID: ***@***.***>

[shivam-Purohit]

Run npm run prettier-write

my bad. I ran a diff cmd. I think we already converting this to local string so no need to touch frontend. Should i also look into LND?

[kaloudis]

Run npm run prettier-write

my bad. I ran a diff cmd. I think we already converting this to local string so no need to touch frontend. Should i also look into LND?

Yes, please look into LND. And please squash fix commits like the latest one if you can.