Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove margin from Message component #2124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shivam-Purohit
Copy link

Description

component integrating a message component should define margins for success/error message component.

closes #1729
This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • [] Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove top from field style now

@myxmaster
Copy link
Contributor

My thoughts on this:

  1. I don't think we need the prop top, there already is a prop mainStyle which can be used to adjust the style of the Text component.
  2. Why does the Text component need top at all? It should be sufficient to define it on the TouchableOpacity.
  3. I think the margin should be 0 by default and only be set to non-zero if it is needed by the integrating component.
  4. styles.field additionally defines marginBottom and padding which should also be removed. There is also a borderRadius which shouldn't have any effect since there is no borderWidth defined (I might be wrong here, I didn't test this).
  5. Additionally to the mainStyle (weird naming) there should also be a style for the TouchableOpacity since margins should be defined here.
  6. We need to check every component that integrates one of these message components and check the margins.

@kaloudis kaloudis force-pushed the master branch 6 times, most recently from 1c682d4 to 2068ca3 Compare November 2, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove margin from Message components
3 participants