Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster connection timeouts for non-Tor connections #2588

Merged

Conversation

myxmaster
Copy link
Contributor

Description

This implements 30s timeout for non-Tor connections (Tor connection timeout is unchanged = 2 minutes).
During initial node connection it stops after first failure.

This fixes #1734.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.9.4 milestone Dec 2, 2024
Copy link
Contributor

@kaloudis kaloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change still need to be added to the CLNRest backend at minimum

Eclair and Spark too, but work is not necessary there as they are deprecated

@myxmaster myxmaster force-pushed the reasonable-timeout-node-connection branch from a6790f6 to b76093c Compare December 17, 2024 15:57
@myxmaster
Copy link
Contributor Author

Right, CLNRest is done now (untested!).

I also noticed this:
When you edit the host of an existing LND node in WalletConfiguration.tsx into something non-reachable and click "save" button, Zeus will try to connect forever. This happened because we didn't do proper promise reject handling. Fixed now.

@myxmaster myxmaster requested a review from kaloudis December 17, 2024 16:03
@myxmaster myxmaster force-pushed the reasonable-timeout-node-connection branch from b76093c to 44c3800 Compare December 18, 2024 00:04
Copy link
Contributor

@kaloudis kaloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit db8bd7d into ZeusLN:master Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Lower timeout in case node is not answering when trying to connect
2 participants