-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance on-chain receive workflow and address type selection #2624
base: master
Are you sure you want to change the base?
Enhance on-chain receive workflow and address type selection #2624
Conversation
7647112
to
3781ae0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a bug. Go to Receive. Select an address type. Autogenerate triggers but no invoice or QR is displayed
3781ae0
to
b856a95
Compare
b856a95
to
0009626
Compare
…electedIndex - for on-chain->receive: replace ClearButton with SettingsButton and do not render LN invoice items addressType modalBox: - use ScrollView - do nothing if same address type as before is picked (also in InvoiceSettings.tsx) - Receive.tsx: autoGenerateOnChainAddress if new address type is picked
0009626
to
23c53ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's another bug here:
When creating a new address from an external account, users are still allowed to change the address type, even though external accounts have fixed address types.
To make matters worse, the newly generated addresses come from the internal on-chain wallet but the label above the QR persists with the external account label.
SettingsButton now hidden for external accounts entirely. |
Description
These changes
Receive
in on-chain swipeable rowselectedIndex !== 2
condition to prevent unnecessary rendering60% heightThis pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: