Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make sure that images can be built on arm64 #855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docker/dockerfiles/backend.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ RUN apt-get update; \
apt-get --no-install-recommends install -y \
# unstract sdk
build-essential libmagic-dev pandoc pkg-config tesseract-ocr \
# pymssql
freetds-dev libssl-dev libkrb5-dev \
# git url
git; \
apt-get clean && rm -rf /var/lib/apt/lists/* /var/cache/apt/archives/*; \
Expand Down
2 changes: 1 addition & 1 deletion docker/dockerfiles/worker.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
ENV PDM_VERSION 2.16.1

RUN apt-get update \
&& apt-get --no-install-recommends install -y docker \
&& apt-get --no-install-recommends install -y docker build-essential pkg-config freetds-dev libssl-dev libkrb5-dev \

Check notice

Code scanning / SonarCloud

Arguments in long RUN instructions should be sorted Low

Sort these package names alphanumerically. See more on SonarQube Cloud
&& apt-get clean && rm -rf /var/lib/apt/lists/* /var/cache/apt/archives/* \
\
&& pip install --no-cache-dir -U pip pdm~=${PDM_VERSION}
Expand Down
5 changes: 4 additions & 1 deletion docker/dockerfiles/x2text.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ ENV PYTHONUNBUFFERED 1
ENV BUILD_CONTEXT_PATH x2text-service
ENV PDM_VERSION 2.16.1

RUN pip install --no-cache-dir -U pip pdm~=${PDM_VERSION}; \
RUN apt-get update; \
apt-get --no-install-recommends install -y \
build-essential pkg-config && \
pip install --no-cache-dir -U pip pdm~=${PDM_VERSION}; \
\
# Creates a non-root user with an explicit UID and adds permission to access the /app folder
# For more info, please refer to https://aka.ms/vscode-docker-python-configure-containers
Expand Down