Handle constrain violation in JDBC drivers which does not throw SQLIn…

…tegrityConstraintViolationException
ZiyamSanthosh · Jun 10, 2024 · 6930189 · 6930189
1 parent 92db6fe
commit 6930189
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/...org/wso2/carbon/identity/application/authentication/framework/store/UserSessionStore.java b/...org/wso2/carbon/identity/application/authentication/framework/store/UserSessionStore.java
@@ -345,17 +345,19 @@ public void storeUserSessionData(String userId, String sessionId) throws UserSes
                 }
             } catch (SQLIntegrityConstraintViolationException e1) {
                 IdentityDatabaseUtil.rollbackTransaction(connection);
-                if (isExistingMapping(userId, sessionId)) {
+                throw new DuplicatedAuthUserException("Mapping between user Id: " + userId + " and session Id: "
+                        + sessionId + " already exists in the database.", e1);
+            } catch (SQLException e1) {
+                IdentityDatabaseUtil.rollbackTransaction(connection);
+                // Handle constrain violation issue in JDBC drivers which does not throw
+                // SQLIntegrityConstraintViolationException
+                if (StringUtils.containsIgnoreCase(e1.getMessage(), "USER_SESSION_STORE_CONSTRAINT")) {
                     throw new DuplicatedAuthUserException("Mapping between user Id: " + userId + " and session Id: "
                             + sessionId + " already exists in the database.", e1);
                 } else {
                     throw new UserSessionException("Error while storing mapping between user Id: " + userId +
                             " and session Id: " + sessionId, e1);
                 }
-            } catch (SQLException e1) {
-                IdentityDatabaseUtil.rollbackTransaction(connection);
-                throw new UserSessionException("Error while storing mapping between user Id: " + userId +
-                        " and session Id: " + sessionId, e1);
             }
         } catch (SQLException e) {
             throw new UserSessionException("Error while storing mapping between user Id: " + userId +

diff --git a/...wso2/carbon/identity/application/authentication/framework/store/UserSessionStoreTest.java b/...wso2/carbon/identity/application/authentication/framework/store/UserSessionStoreTest.java
@@ -235,10 +235,8 @@ public void testExceptionAtStoreUserSessionDataForDuplicatedSession(String userI
             Exception {
 
         try (Connection connection = getConnection(DB_NAME);
-             Connection connection1 = getConnection(DB_NAME);
              MockedStatic<IdentityDatabaseUtil> identityDatabaseUtil = mockStatic(IdentityDatabaseUtil.class)) {
             mockIdentityDataBaseUtilConnection(connection, true, identityDatabaseUtil);
-            mockIdentityDataBaseUtilConnection(connection1, false, identityDatabaseUtil);
             UserSessionStore.getInstance().storeUserSessionData(userId, sessionId);
         }
     }