QuestHelperPlugin file refactor #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
reviewed
Sep 29, 2023
...main/java/com/questhelper/runeliteobjects/extendedruneliteobjects/RuneliteObjectManager.java
Outdated
Show resolved
Hide resolved
...main/java/com/questhelper/runeliteobjects/extendedruneliteobjects/RuneliteObjectManager.java
Show resolved
Hide resolved
Zoinkwiz
force-pushed
the
code-refactor-2
branch
from
e7c8cc6 to
c29e78e
Compare
This takes over the Overlay management from QuestHelperPlugin.
This is intended to handle bank behaviour for the QuestHelperPlugin.
Merges Cheerer with the overall RuneliteObjectMananger.
This manager handles starting up and closing down helpers.
Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
Zoinkwiz
force-pushed
the
code-refactor-2
branch
from
d580dc7 to
6066aa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to help clean up a lot of the bloat inside the QuestHelperPlugin file, delegating instead more to other manager files and reducing replicated code and outdated code (for example for the Cheerer and the menuoptions).
Any feedback on ensuring this is actually implementing decent practices, and what further improvements can be made would be much appreciated!