Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kandarin easy achievement diary steps per issue #1087 #1563

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

andersenalan
Copy link
Contributor

@andersenalan andersenalan commented May 16, 2024

Resolves #1087

@andersenalan
Copy link
Contributor Author

@Zoinkwiz can I get a review? I work in gitlab in my day job so I am unfamiliar with github. I think you need to kick off the workflow.

Copy link
Owner

@Zoinkwiz Zoinkwiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for tackling this! What you've done should update the sidebar's order, but the order defined in loadStep(), as added to the doEasy ConditionalStep also needs to be updated to match (like

).

Once that's done this should be good to be merged!

@andersenalan
Copy link
Contributor Author

Ah thanks, I had originally changed those but noticed the actual panel didn't change so I backed them out. Was having trouble actually testing since I don't have a new account that can actually complete the steps. I'll make those changes!

@Zoinkwiz
Copy link
Owner

No worries, also if you ever need an account without any tasks done usually you can hop to a quest speedrunning world and have one with no reqs there.

@Zoinkwiz Zoinkwiz merged commit 78c2601 into Zoinkwiz:master Nov 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easy Kandarin streamlining
2 participants