feat: Remove html usage #1777
Merged
feat: Remove html usage #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTML throws as a warning for plugin-hub PRs, so where we can it makes sense to avoid it.
pajlada
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
I have tested & confirmed the following work as expected:
- tooltips with newlines using
\ninstead of html/br JTextAreausage in Assist Level- "Skill filtering" buttons/selectors (although the button does jump in position a bit when any skills are filtered - I don't really mind)
- When no quests match my filter
- The dropdown menus for filters/difficulty/ordering
- Herb run configuration
- Enemies to defeat when multiple lines are listed
- Quest Notes
- Quest list
- Quest selection
- Quest steps
- Quest sidebar category titles
- Quest reward list
I've tested everything except actually doing a quest
pajlada
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML throws as a warning for plugin-hub PRs, so where we can it makes sense to avoid it.
Not 100% sure this has been done right, but seems pretty much right, and everything from what I've scoured looks the same with these changes.