Varlamore Part 2 Quest Cleanup #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make it easier to use any QuestStep in PuzzleWrapperStep, as well as generally making it more concise when using various dialog adding and highlighting in the future.
This makes it easier to use NpcStep in things such as PuzzleWrapperStep.
As some steps may want to default to different other steps upon being hidden (for example in a PuzzleWrapperStep), this ensures that the sidebar highlight check is re-run if a step is hidden/shown.
This makes use of the actual active sidebar step for the queststeppanel, rather than a local variable representing it based on a last-known state. This should ensure that panels are properly checked, and there's no chance of this variable not representing the actual quest state. This does mean recolour of the sidebar can occur on things which are already set, but I don't think this should have any noted performance changes.
Zoinkwiz
force-pushed
the
varlamore-p2-quest-cleanup
branch
from
0bfb80e to
75049a6
Compare
pajlada
approved these changes
Oct 23, 2024
| @@ -223,7 +221,8 @@ public void setupSteps() | |||
| "back already!", | |||
| "Think of the Varlamorian children who won't get to see this artefact.", "You should give Varlamore a chance before stealing their stuff.", | |||
| "This is stealing! Thieving! Taking what's not yours!", "I thought archaeology was cool. I didn't realise it was just thieving!", | |||
| "How would you feel if someone came in here and stole all your stuff?", "You're hoarding artefacts, but you should be sharing them!"); | |||
| "How would you feel if someone came in here and stole all your stuff?", "You're hoarding artefacts, but you should be sharing them!") | |||
| .puzzleWrapStep("Work out how to shame Curator Haig Halen, get the meter to 100%."); | |||
There was a problem hiding this comment.
This builder-like API with the puzzle wrap step helper function is neat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily focusing on implementing the PuzzleWrapperStep to the newest Varlamore quests.
As part of this, I made a few QuestStep functions return said QuestStep. This is intended to make it a bit easier to make things like PuzzleWrapperStep in the future when there's various things needing to be applied to the base QuestStep.
I also needed to fix a bug in the sidebar with how substeps were detected for section highlighting, as it was causing the sidebar to not highlight correctly for substeps of puzzle wrappers.
The parts I've added a puzzle hide to are:
Heart of Darkness
Ethically Acquired Antiquities
Death on the Isle
None added at present, as it is kinda all a puzzle. I think we could consider adding some, basically making it so sections are more like 'Search the wine cellar for all clues', 'Accuse the person you think is the murderer', etc. But I'd like that to be a discussion as I'm not 100% sure on it.
Meat and Greet
None needed to be added as @pajlada is a competent individual who's very good at coding ❤️