Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly order all quests by release date #1810

Closed
wants to merge 1 commit into from

Conversation

Kumagor0
Copy link
Contributor

A possible fix for #1809

@pajlada
Copy link
Contributor

pajlada commented Oct 19, 2024

Yours didn't compile, so I went ahead and made a new PR with this + some other changes we've wanted to make for a while

#1811

Will add you as a co-author to the final squashed PR

@Kumagor0
Copy link
Contributor Author

@pajlada thank you, was it because I fixed PERILOUS_MOON to PERILOUS_MOONS without fixing this file as well? Maybe you want to do that properly too if you know how to.

@pajlada
Copy link
Contributor

pajlada commented Oct 19, 2024

@pajlada thank you, was it because I fixed PERILOUS_MOON to PERILOUS_MOONS without fixing this file as well? Maybe you want to do that properly too if you know how to.

Yeah there's actually a few others where we don't really use the "correct" name, but I thought that'd be best to catch in a followup PR instead

DESERT_TREASURE should be DESERT_TREASURE_I now that DT2 is out
THE_MAGE_ARENA should be MAGE_ARENA_I
THE_MAGE_ARENA_II should be MAGE_ARENA_II
ENCHANTED_KEY should be THE_ENCHANTED_KEY

using the names from here: https://oldschool.runescape.wiki/w/Quests/List

@Kumagor0 Kumagor0 closed this Oct 20, 2024
@Kumagor0 Kumagor0 deleted the fix-order-by-release branch October 20, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants