Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented add-new-reservation functionality #24

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

BryteLitty
Copy link
Collaborator

In this PR, I did the following:

  • Implemented a functionality that takes data from the front end and records it in the involvement API.
  • created a function that updates the Reservations section on the modal page with reservation info on the selected item

Copy link
Collaborator

@Ofarouq310 Ofarouq310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved ✔️

Hi @BryteLitty ,

Your milestone is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

giphy

Highlights

✔️No linter errors.
✔️Correct GitHub Flow.
✔️Milestone worked as expected.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

  • [OPTIONAL] To improve the UI more, in case of entering a date that is invalid, you can display an error message to the user or a similar idea that will satisfy the suggestion.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants