Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

Commit

Permalink
fix: Operations Coercion (#49)
Browse files Browse the repository at this point in the history 
* fix: Operations Coercion

Signed-off-by: Daniel Tes Carrasque <daniel@zup.com.br>

* self capture fix

Signed-off-by: Daniel Tes Carrasque <daniel@zup.com.br>

* update codeowners

Signed-off-by: Daniel Tes Carrasque <daniel@zup.com.br>

Signed-off-by: Daniel Tes Carrasque <daniel@zup.com.br>
  • Loading branch information
@dantes-git
dantes-git authored Nov 23, 2022
1 parent e89bada commit 9753f65
Show file tree
Hide file tree
Showing 5 changed files with 186 additions and 372 deletions.
2 changes: 1 addition & 1 deletion CODEOWNERS
View file
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
CODEOWNERS
* @dantes-git @tiagoperes @carlossteinzup @hectorcustodiozup @lucasfonsecazup
* @tiagoperes @arthurbleilzup @hernandazevedozup @dantes-git
339 changes: 94 additions & 245 deletions ...ContextExpression/Expression/OperationEvaluation/OperationComparisonEvaluationTests.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,266 +17,115 @@
import XCTest
@testable import Beagle

// swiftlint:disable force_unwrapping

final class OperationComparisonEvaluationTests: OperationEvaluationTests {

func testGt() {
let view = UIView()

let operations = [
Operation(rawValue: "gt(2, 1)")!,
Operation(rawValue: "gt(1, 1)")!,
Operation(rawValue: "gt(1, 2)")!,

Operation(rawValue: "gt(2.0, 1.0)")!,
Operation(rawValue: "gt(2.0, 1)")!,
Operation(rawValue: "gt(1.0, 1)")!,
Operation(rawValue: "gt(1.0, 2)")!,

Operation(rawValue: "gt('2', 1.0)")!,
Operation(rawValue: "gt('2', 1)")!,
Operation(rawValue: "gt('2', '1')")!,
Operation(rawValue: "gt('1', '1')")!,
Operation(rawValue: "gt('1', '1.0')")!,
Operation(rawValue: "gt('1.0', 2.0)")!,
Operation(rawValue: "gt('1.0', '2.0')")!,

Operation(rawValue: "gt(true, 2)")!
]

let result = operations.map { $0.evaluate(in: view) }

let expexted: [DynamicObject] = [
true,
false,
false,

true,
true,
false,
false,

true,
true,
true,
false,
false,
false,
false,

false
]

XCTAssertEqual(result, expexted)
XCTAssertEqual(evalOperation("gt(2, 1)"), true)
XCTAssertEqual(evalOperation("gt(1, 1)"), false)
XCTAssertEqual(evalOperation("gt(1, 2)"), false)

XCTAssertEqual(evalOperation("gt(2.0, 1.0)"), true)
XCTAssertEqual(evalOperation("gt(2.0, 1)"), true)
XCTAssertEqual(evalOperation("gt(1.0, 1)"), false)
XCTAssertEqual(evalOperation("gt(1.0, 2)"), false)

XCTAssertEqual(evalOperation("gt('2', 1.0)"), true)
XCTAssertEqual(evalOperation("gt('2', 1)"), true)
XCTAssertEqual(evalOperation("gt('2', '1')"), true)
XCTAssertEqual(evalOperation("gt('1', '1')"), false)
XCTAssertEqual(evalOperation("gt('1', '1.0')"), false)
XCTAssertEqual(evalOperation("gt('1.0', 2.0)"), false)
XCTAssertEqual(evalOperation("gt('1.0', '2.0')"), false)

XCTAssertEqual(evalOperation("gt(true, 2)"), false)
}

func testGte() {
let view = UIView()

let operations = [
Operation(rawValue: "gte(2, 1)")!,
Operation(rawValue: "gte(1, 1)")!,
Operation(rawValue: "gte(1, 2)")!,

Operation(rawValue: "gte(2.0, 1.0)")!,
Operation(rawValue: "gte(2.0, 1)")!,
Operation(rawValue: "gte(1.0, 1)")!,
Operation(rawValue: "gte(1.0, 2)")!,

Operation(rawValue: "gte('2', 1.0)")!,
Operation(rawValue: "gte('2', 1)")!,
Operation(rawValue: "gte('2', '1')")!,
Operation(rawValue: "gte('1', '1')")!,
Operation(rawValue: "gte('1', '1.0')")!,
Operation(rawValue: "gte('1.0', 2.0)")!,
Operation(rawValue: "gte('1.0', '2.0')")!,

Operation(rawValue: "gte(true, 2)")!
]

let result = operations.map { $0.evaluate(in: view) }

let expexted: [DynamicObject] = [
true,
true,
false,

true,
true,
true,
false,

true,
true,
true,
true,
true,
false,
false,

false
]

XCTAssertEqual(result, expexted)
XCTAssertEqual(evalOperation("gte(2, 1)"), true)
XCTAssertEqual(evalOperation("gte(1, 1)"), true)
XCTAssertEqual(evalOperation("gte(1, 2)"), false)

XCTAssertEqual(evalOperation("gte(2.0, 1.0)"), true)
XCTAssertEqual(evalOperation("gte(2.0, 1)"), true)
XCTAssertEqual(evalOperation("gte(1.0, 1)"), true)
XCTAssertEqual(evalOperation("gte(1.0, 2)"), false)

XCTAssertEqual(evalOperation("gte('2', 1.0)"), true)
XCTAssertEqual(evalOperation("gte('2', 1)"), true)
XCTAssertEqual(evalOperation("gte('2', '1')"), true)
XCTAssertEqual(evalOperation("gte('1', '1')"), true)
XCTAssertEqual(evalOperation("gte('1', '1.0')"), true)
XCTAssertEqual(evalOperation("gte('1.0', 2.0)"), false)
XCTAssertEqual(evalOperation("gte('1.0', '2.0')"), false)

XCTAssertEqual(evalOperation("gte(true, 2)"), false)
}

func testLt() {
let view = UIView()

let operations = [
Operation(rawValue: "lt(2, 1)")!,
Operation(rawValue: "lt(1, 1)")!,
Operation(rawValue: "lt(1, 2)")!,

Operation(rawValue: "lt(2.0, 1.0)")!,
Operation(rawValue: "lt(2.0, 1)")!,
Operation(rawValue: "lt(1.0, 1)")!,
Operation(rawValue: "lt(1.0, 2)")!,

Operation(rawValue: "lt('2', 1.0)")!,
Operation(rawValue: "lt('2', 1)")!,
Operation(rawValue: "lt('2', '1')")!,
Operation(rawValue: "lt('1', '1')")!,
Operation(rawValue: "lt('1', '1.0')")!,
Operation(rawValue: "lt('1.0', 2.0)")!,
Operation(rawValue: "lt('1.0', '2.0')")!,

Operation(rawValue: "lt(true, 2)")!
]

let result = operations.map { $0.evaluate(in: view) }

let expexted: [DynamicObject] = [
false,
false,
true,

false,
false,
false,
true,

false,
false,
false,
false,
false,
true,
true,

false
]

XCTAssertEqual(result, expexted)
XCTAssertEqual(evalOperation("lt(2, 1)"), false)
XCTAssertEqual(evalOperation("lt(1, 1)"), false)
XCTAssertEqual(evalOperation("lt(1, 2)"), true)

XCTAssertEqual(evalOperation("lt(2.0, 1.0)"), false)
XCTAssertEqual(evalOperation("lt(2.0, 1)"), false)
XCTAssertEqual(evalOperation("lt(1.0, 1)"), false)
XCTAssertEqual(evalOperation("lt(1.0, 2)"), true)

XCTAssertEqual(evalOperation("lt('2', 1.0)"), false)
XCTAssertEqual(evalOperation("lt('2', 1)"), false)
XCTAssertEqual(evalOperation("lt('2', '1')"), false)
XCTAssertEqual(evalOperation("lt('1', '1')"), false)
XCTAssertEqual(evalOperation("lt('1', '1.0')"), false)
XCTAssertEqual(evalOperation("lt('1.0', 2.0)"), true)
XCTAssertEqual(evalOperation("lt('1.0', '2.0')"), true)

XCTAssertEqual(evalOperation("lt(true, 2)"), false)
}

func testLte() {
let view = UIView()

let operations = [
Operation(rawValue: "lte(2, 1)")!,
Operation(rawValue: "lte(1, 1)")!,
Operation(rawValue: "lte(1, 2)")!,

Operation(rawValue: "lte(2.0, 1.0)")!,
Operation(rawValue: "lte(2.0, 1)")!,
Operation(rawValue: "lte(1.0, 1)")!,
Operation(rawValue: "lte(1.0, 2)")!,

Operation(rawValue: "lte('2', 1.0)")!,
Operation(rawValue: "lte('2', 1)")!,
Operation(rawValue: "lte('2', '1')")!,
Operation(rawValue: "lte('1', '1')")!,
Operation(rawValue: "lte('1', '1.0')")!,
Operation(rawValue: "lte('1.0', 2.0)")!,
Operation(rawValue: "lte('1.0', '2.0')")!,

Operation(rawValue: "lte(true, 2)")!
]

let result = operations.map { $0.evaluate(in: view) }

let expexted: [DynamicObject] = [
false,
true,
true,

false,
false,
true,
true,

false,
false,
false,
true,
true,
true,
true,

false
]

XCTAssertEqual(result, expexted)
XCTAssertEqual(evalOperation("lte(2, 1)"), false)
XCTAssertEqual(evalOperation("lte(1, 1)"), true)
XCTAssertEqual(evalOperation("lte(1, 2)"), true)

XCTAssertEqual(evalOperation("lte(2.0, 1.0)"), false)
XCTAssertEqual(evalOperation("lte(2.0, 1)"), false)
XCTAssertEqual(evalOperation("lte(1.0, 1)"), true)
XCTAssertEqual(evalOperation("lte(1.0, 2)"), true)

XCTAssertEqual(evalOperation("lte('2', 1.0)"), false)
XCTAssertEqual(evalOperation("lte('2', 1)"), false)
XCTAssertEqual(evalOperation("lte('2', '1')"), false)
XCTAssertEqual(evalOperation("lte('1', '1')"), true)
XCTAssertEqual(evalOperation("lte('1', '1.0')"), true)
XCTAssertEqual(evalOperation("lte('1.0', 2.0)"), true)
XCTAssertEqual(evalOperation("lte('1.0', '2.0')"), true)

XCTAssertEqual(evalOperation("lte(true, 2)"), false)
}

func testEq() {
let view = UIView()

let operations = [
Operation(rawValue: "eq(2, 1)")!,
Operation(rawValue: "eq(1, 1)")!,
Operation(rawValue: "eq(1, 2)")!,

Operation(rawValue: "eq(2.0, 1.0)")!,
Operation(rawValue: "eq(2.0, 1)")!,
Operation(rawValue: "eq(1.0, 1)")!,
Operation(rawValue: "eq(1.0, 2)")!,

Operation(rawValue: "eq('2', 1.0)")!,
Operation(rawValue: "eq('2', 1)")!,
Operation(rawValue: "eq('2', '1')")!,
Operation(rawValue: "eq('1', '1')")!,
Operation(rawValue: "eq('1', '1.0')")!,
Operation(rawValue: "eq('1.0', 2.0)")!,
Operation(rawValue: "eq('1.0', '2.0')")!,

Operation(rawValue: "eq(true, true)")!,
Operation(rawValue: "eq(true, false)")!,
Operation(rawValue: "eq('no', 'no')")!,
Operation(rawValue: "eq('no', 'yes')")!,
Operation(rawValue: "eq(true, 2)")!
]

let result = operations.map { $0.evaluate(in: view) }

let expexted: [DynamicObject] = [
false,
true,
false,

false,
false,
true,
false,

false,
false,
false,
true,
true,
false,
false,

true,
false,
true,
false,
false
]

XCTAssertEqual(result, expexted)
XCTAssertEqual(evalOperation("eq(2, 1)"), false)
XCTAssertEqual(evalOperation("eq(1, 1)"), true)
XCTAssertEqual(evalOperation("eq(1, 2)"), false)

XCTAssertEqual(evalOperation("eq(2.0, 1.0)"), false)
XCTAssertEqual(evalOperation("eq(2.0, 1)"), false)
XCTAssertEqual(evalOperation("eq(1.0, 1)"), true)
XCTAssertEqual(evalOperation("eq(1.0, 2)"), false)

XCTAssertEqual(evalOperation("eq('2', 1.0)"), false)
XCTAssertEqual(evalOperation("eq('2', 1)"), false)
XCTAssertEqual(evalOperation("eq('2', '1')"), false)
XCTAssertEqual(evalOperation("eq('1', '1')"), true)
XCTAssertEqual(evalOperation("eq('1', '1.0')"), true)
XCTAssertEqual(evalOperation("eq('1.0', 2.0)"), false)
XCTAssertEqual(evalOperation("eq('1.0', '2.0')"), false)

XCTAssertEqual(evalOperation("eq(true, true)"), true)
XCTAssertEqual(evalOperation("eq(true, false)"), false)
XCTAssertEqual(evalOperation("eq('no', 'no')"), true)
XCTAssertEqual(evalOperation("eq('no', 'yes')"), false)
XCTAssertEqual(evalOperation("eq(true, 2)"), false)
}

}
Loading

0 comments on commit 9753f65

Please sign in to comment.