Merge pull request #14 from a-company-jp/configure-github-cors

🔧 configure cors for github.com, remove cloud domain mapping
a-company-jp · Apr 13, 2024 · 9fdcd52 · 9fdcd52
2 parents 8554e1c + 0076cbe
commit 9fdcd52
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/envs/dev/cloudrun.tf b/envs/dev/cloudrun.tf
@@ -32,16 +32,3 @@ resource "google_cloud_run_service_iam_policy" "noauth" {
 
   policy_data = data.google_iam_policy.noauth.policy_data
 }
-
-resource "google_cloud_run_domain_mapping" "domain-mapping" {
-  location = "asia-northeast1"
-  name     = "lgtm.a.shion.pro"
-
-  metadata {
-    namespace = var.project_id
-  }
-
-  spec {
-    route_name = google_cloud_run_service.cloudrun-dev-main-backend.name
-  }
-}
diff --git a/envs/dev/gcs.tf b/envs/dev/gcs.tf
@@ -7,7 +7,7 @@ resource "google_storage_bucket" "public_image_bucket" {
   uniform_bucket_level_access = true
 
   cors {
-    origin          = [""]
+    origin          = ["https://github.com"]
     method          = ["GET"]
     response_header = ["*"]
     max_age_seconds = 3600