Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix incorrect method calls in sysinfo usage #528

Closed
wants to merge 2 commits into from

Conversation

famouswizard
Copy link

This update addresses an issue in how methods from the sysinfo library were being used. Previously, name, os_version, and host_name were incorrectly called as static methods on System.
However, these methods are instance-specific and must be invoked on a System object.

The corrected implementation ensures proper instantiation of the System class before accessing these methods, aligning with the library's intended usage.

This fix improves compatibility and eliminates potential runtime errors.

Copy link
Collaborator

@moodlezoup moodlezoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like they are in fact static?

@moodlezoup moodlezoup closed this Dec 18, 2024
@famouswizard famouswizard deleted the patch-1 branch December 18, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants