Adapt changes for specification v3.1 #352
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the invariant declaring the maximum length of `Identifier` was set to `2000`. We had already adapted this to `2024` according to [aas-specs#306], however the specification was corrected to `2048` in [aas-specs#306]. We therefore adapt the invariant to a maximum length of `2048` [aas-specs#306](admin-shell-io/aas-specs#306)
Previously, the invariant declaring the maximum length of `Value_type_IEC_61360` was set to `2000`. Decided in [aas-specs#306] and specified in [aas-specs-iec61360#21] this was adapted to `2048`. We therefore adapt the invariant to a maximum length of `2048` [aas-specs#306](admin-shell-io/aas-specs#306) [aas-specs-iec61360#21](admin-shell-io/aas-specs-iec61360#21)
Previously, `RelationshipElement.first` and `RelationshipElement.second` were mandatory attributes. As decided in [aas-specs#412] and specified in [aas-specs#431], we now make these attributes optional. Furthermore, we extend these changes to the constructor of `AnnotatedRelationshipElement`. Fixes #340 [aas-specs#412](admin-shell-io/aas-specs#412) [aas-specs#431](admin-shell-io/aas-specs#431)
Previously, `File.content_type` and `Blob.content_type` were mandatory attributes. As decided in [aas-specs#412] and specified in [aas-specs#431], we now make these attributes optional. Fixes #339 [aas-specs#412](admin-shell-io/aas-specs#412) [aas-specs#431](admin-shell-io/aas-specs#431)
Version 3.1 of the metamodel changes the `Path_type` to be conforming to RFC 2396 (see [spec-link]). As we did not have a verifcation function for this RFC, we add the function `matches_RFC_2396` based on this [abnf_to_regexp test case] and adapt the `Path_type` invariant accordingly. [spec-link](https://admin-shell-io.github.io/aas-specs-antora/IDTA-01001/v3.1/spec-metamodel/datatypes.html#PathType) [abnf_to_regexp test case](https://github.com/aas-core-works/abnf-to-regexp/blob/main/test_data/nested-python/rfc2396/expected.py)
Previously, the pattern of `matches_xs_any_URI` followed RFC 3987, which actually specifies IRIs. We adapt the pattern of this verification function to follow RFC 2396, as amended by RFC 2732, implementing the XSD v1.0 specification verbatim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks the adapted changes of the specification for the version 3.1 release.
Once stable, we should merge this into the main branch.