Merge pull request #68 from bgd-labs/feat/upgrade-tooling

chore: upgrade tooling

.github/workflows/comment.yml

@@ -17,7 +17,7 @@ jobs:
   comment:
     name: Comment Bot
     runs-on: ubuntu-latest
-    # workflow run triggeres on all types of "completed" including "cancelled" and similar
+    # workflow run triggers on all types of "completed" including "cancelled" and similar
     # we want this action to only run on a success & failure though
     if: ${{ github.event.workflow_run.conclusion == 'success' || github.event.workflow_run.conclusion == 'failure' }}
     steps:

.github/workflows/test.yml

@@ -16,13 +16,16 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+      - uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6
         with:
-          submodules: recursive
-      - uses: oven-sh/setup-bun@8f24390df009a496891208e5e36b8a1de1f45135
-      - name: Install node dependencies
-        run: bun install
+          node-version-file: .nvmrc
+          cache: "npm"
+
+      - name: install
+        run: npm ci --prefer-offline --no-audit
+
       - name: lint
-        run: bun run lint --check
+        run: npm run lint
 
   test:
     name: Foundry build n test
@@ -33,15 +36,18 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: recursive
-      - uses: oven-sh/setup-bun@8f24390df009a496891208e5e36b8a1de1f45135
+      - uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6
+        with:
+          node-version-file: .nvmrc
+          cache: "npm"
 
       - name: Install Foundry
         uses: foundry-rs/foundry-toolchain@8f1998e9878d786675189ef566a2e4bf24869773
         with:
           version: nightly
 
       - name: Install node dependencies
-        run: bun install
+        run: npm ci --prefer-offline --no-audit
 
       - name: Run Forge build
         run: |

.gitignore

@@ -17,8 +17,8 @@ downloads/
 .vscode
 lcov*
 
-# well, looks strange to ignore package-lock, but we have only pretter and it's temproray
-package-lock.json
+yarn.lock
+bun.lockb
 node_modules
 
 # ignore foundry deploy artifacts

.nvmrc

@@ -0,0 +1 @@
+20

README.md

@@ -24,8 +24,8 @@ cp .env.example .env
 
 forge install
 
-# optional, to install prettier
-bun install
+# required for tests & linting
+npm install
 ```
 
 <br>

certora/stata/harness/pool/SymbolicLendingPool.sol

@@ -93,10 +93,7 @@ contract SymbolicLendingPool {
     return reserve.configuration;
   }
 
-  function getVirtualUnderlyingBalance(
-    address asset
-  ) external view virtual returns (uint128) {
+  function getVirtualUnderlyingBalance(address asset) external view virtual returns (uint128) {
     return reserve.virtualUnderlyingBalance;
   }
-
 }