feat: add foundry test for bitmaps #967
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LHerskind
requested review from
The-3D,
miguelmtzinf,
foodaka,
eboadom,
kyzia551 and
sakulstra
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives #641 a splash of fresh paint as it was somewhat outdated from when I created that PR back in the days. Created as a separate PR instead of extending as that was easiest when I no longer is part of the Aave github org so seemed like it would not let me push updates to it.
The pr adds some property based tests for the configuration libraries where we were using a lot of bitmap magic to ensure that it goes as planned.
The pr is not extending what is being run in CI since I am not sure what your preferred method would be, so letting your decide that.