-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modular Gho Stewards #414
Merged
Merged
Modular Gho Stewards #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
* test: role setup * test: add basic fork tests * fix: requested changes * fix: use aave address book * fix: Update aave address book dep * test: Add arbitrum tests * test: Add rate limit tests * test: Add gho borrow rate tests * fix: Use appropriate controlled facilitator * fix: remove unused import * fix: Add arbitrum env var to ci --------- Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>
miguelmtzinf
approved these changes
Sep 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support CCIP controls for GhoSteward
Closes #415
Background
We've decided to split the GhoStewardV2 into multiple different stewards, each with independent responsibilities, in order to remove the need to redeploy the entire steward contract whenever we wish to make an upgrade or change. Now, only the corresponding steward will need a change, and the rest can stay untouched.
In addition, we've implemented some new features to allow for controlling parameters related to CCIP.
Usage
Allows approved risk provider to change GHO, GSM and CCIP parameters.
Steps from governance to work as intended
The following contracts must be granted these roles by the DAO:
Owner of the contract (DAO) needs to add each facilitator (GHO AToken/GSM) to a controlled list in
GhoBucketSteward
, withsetControlledFacilitator
methodFixedRateStrategyFactory must be deployed before deploying the
GhoAaveSteward
contract, as its used for creating fixed rate strategies for updating the GHO borrow rate.Limitations on calls and/or parameters:
General:
Authorized Parties
The following functions can only be called by the risk council:
GhoBucketSteward:
updateFacilitatorBucketCapacity
:GhoAaveSteward:
updateGhoBorrowCap
:updateGhoBorrowRate
:GHO_BORROW_RATE_MAX
and is an absolute max on the final value, whereas the other update conditions enforce how much a value is allowed to change on each individual update (and there is no enforced maximum value)updateGhoSupplyCap
GhoCcipSteward:
updateBridgeLimit
:updateRateLimit
:GhoGsmSteward:
updateGsmExposureCap
:updateGsmBuySellFees
:Management:
The following functions can only be called by the owner (the Aave DAO)
setControlledFacilitator
on GhoBucketStewardsetRiskConfig
on GhoAaveStewardConsiderations:
setControlledFacilitator
withfalse
if they want to disable it for certain GSMs