USTB GSM Implementation #431

yan-man · 2024-10-15T13:43:28Z

closes #430

…enforce no remaining balance in converter

test: remaining gho balance

…ariables

…oBalance

…specific

height · 2024-10-15T13:43:33Z

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

yan-man added 30 commits August 30, 2024 18:20

feat: skeleton for GsmConverter buyAsset

ab52741

fix: resolve compilation issues

b102136

feat: initialize interface

dd74cc2

refactor: move files to separate directory

023a6b4

fix: resolve interface function visibility

750eb61

test: initialize constructor unit test

038e3be

test: testRevertConstructorZeroAddressParams;

c574b35

test: initialize BUIDL-specific test GSM

56ab408

test: add check on buyAsset for minAmount

5760379

test: happy path for converter buyAsset

bb08c59

test: events testing + happy path buyAsset

eb4a888

test: test revert cases

8ca6481

fix: resolve tests involving facilitator due to new one added

2942b36

fix: resolve fuzz test input with zero address

ebca6d7

feat: rescueTokens implementation + tests

cff5b1f

fix: convert to Ownable

4d2abe2

fix: validate calculated ghoAmount matches ghoSold, reset approvals, …

2faf8a6

…enforce no remaining balance in converter

test: create mockGSM to test unmatching gho amount case

bc05a7d

refactor: methods re-order

0c1beb2

refactor: rename mock

117eda8

test: remaining gho balance

test: test coverage for remaining token balances

4f4603c

feat: init buyAssetWithSig

1dbff49

test: happy path test for buyAssetWithSig

bce34e7

test: simplify testBuyAssetWithSig, add testBuyAssetWithSigExactDeadline

62657ee

test: add testRevertBuyAssetWithSigExpiredSignature

522ada9

test: add testRevertBuyAssetWithSigInvalidSignature

b60751d

test: add testRevertBuyAssetWithSigInvalidAmount

6d90a66

test: refer to proper value for BUIDL gsm exposure

ea90912

test: resolve test assertion on remaining gsm gho balance

c9140c5

test: clean up assertion failure messages, reference different test v…

14fc942

…ariables

yan-man added 25 commits September 11, 2024 08:13

refactor: capitalize variable name

409944b

refactor: use more precise variable reference

7b96c4c

test: add testRevertSellAssetWithSigInvalidAmount

74da86e

test: add testBuyAssetWithDonatedTokens

f0c35fd

test: add testSellAssetDonatedTokens

57df1d7

test: fuzz for donated token amounts

4b1ed4e

test: clean up var references and add testFuzzSellAssetMaxAmount

fdc083e

test: clean up var reference

df84a21

test: add fuzz tests, testRevertSellAssetWithSigInvalidNonce

91fb7b9

test: add testRevertBuyAssetWithSigInvalidNonce

655b0b0

test: remove mock test files from coverage

d0f89f2

fix: remove need to upgrade gsm to trigger error

8a47c39

Merge branch 'main' into feat/gsm-buidl

6e208a2

feat: init GsmConverter overview doc

3d7cbb0

test: reduce unneeded mock code for MockGsmFailedSellAssetRemainingGh…

feeda78

…oBalance

refactor: rename subscription event

53dc395

test: resolve tests from event change, rename mock files to be BUIDL-…

b48a0be

…specific

Merge branch 'main' into feat/gsm-buidl

ae2dec4

refactor: rename issuance to subscription

72ee91d

test: add mock USTB subscription/redemption contract

9a686d3

feat: add todo notes on subscription fees

16a5d59

fix: account for subscription fee, resolve tests, param names

c943e73

test: end prank

0201eea

Merge branch 'feat/gsm-buidl' into feat/gsm-ustb

a32f7ee

test: update mock comments

a7a828f

yan-man requested review from miguelmtzinf and foodaka as code owners October 15, 2024 13:43

yan-man closed this Oct 15, 2024

yan-man mentioned this pull request Oct 15, 2024

USTB GSM Implementation #432

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

USTB GSM Implementation #431

USTB GSM Implementation #431

yan-man commented Oct 15, 2024

height bot commented Oct 15, 2024

USTB GSM Implementation #431

USTB GSM Implementation #431

Conversation

yan-man commented Oct 15, 2024

height bot commented Oct 15, 2024