Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for packer build #19

Closed
wants to merge 4 commits into from
Closed

Conversation

oxr463
Copy link
Contributor

@oxr463 oxr463 commented Oct 4, 2022

Pull request checklist

Description

  • Add packer init and packer build tests.
  • Run unit-tests via tox on PR and Push for GitHub Actions.
  • Ignore .eggs/ directory.

Reference(s):

Screenshots (if appropriate):

Types of changes

  • This change requires a documentation update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • Lint and unit tests pass locally with my changes.
  • All new and existing tests passed.

tests/test_packer.py Outdated Show resolved Hide resolved
Since we use init for the setup, we should know if it is working
@oxr463 oxr463 changed the title Draft: Add unit test for packer build Add unit test for packer build Oct 29, 2022
@oxr463 oxr463 marked this pull request as ready for review October 29, 2022 17:20
@oxr463
Copy link
Contributor Author

oxr463 commented Oct 29, 2022

@abhi1693 please review.

@abhi1693
Copy link
Owner

abhi1693 commented Nov 6, 2022

@oxr463 Could you also add a GitHub CI workflow for this to run on every push and pull request?

Ignore .eggs directory
@oxr463 oxr463 requested a review from abhi1693 as a code owner December 1, 2022 02:05
@oxr463
Copy link
Contributor Author

oxr463 commented Dec 1, 2022

@oxr463 Could you also add a GitHub CI workflow for this to run on every push and pull request?

This is done, however, I was expecting tox to fail on all of the unimplemented tests but for some reason it passed.

@abhi1693
Copy link
Owner

abhi1693 commented Dec 1, 2022

@oxr463 Something is not right with the implementation. I don't see any runs or summary of the runs in the tox step

@abhi1693 abhi1693 removed their request for review May 12, 2023 13:37
@abhi1693
Copy link
Owner

Ping me when this is ready

@abhi1693 abhi1693 closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants