Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chemicals in Cosmetics Analysis #448

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

ellow0rld
Copy link
Contributor

@ellow0rld ellow0rld commented Dec 11, 2023

Pull Request for ML-Crate 💡

Issue Title: Chemicals in Cosmetics Analysis

  • Info about the related issue (Aim of the project) : Create a Data analysis model for analyzing the chemicals present in the cosmetics.
  • Name: Madhu Shree Aravindan
  • GitHub ID: ellow0rld
  • Idenitfy yourself: Contributor (KWOC'23)

Closes: #445

Describe the add-ons or changes you've made 📃

I have added 4 files:

  • Dataset
  • Images
  • Model
  • requirements.txt

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @ellow0rld :)

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. KWOC 2023 labels Dec 11, 2023
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Your PR is approved and ready to be merged.
@ellow0rld

@abhisheks008 abhisheks008 merged commit a0a2e43 into abhisheks008:main Dec 11, 2023
1 check passed
@abhisheks008
Copy link
Owner

Hi @ellow0rld can you please share your email ID with me for further communication purposes? You can DM me in Discord or you can simply drop a mail to me about the same.

@ellow0rld
Copy link
Contributor Author

ellow0rld commented Dec 11, 2023 via email

@abhisheks008
Copy link
Owner

Hi @ellow0rld GitHub doesn't allow you to send personal information like this. You can DM me in Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. KWOC 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chemicals in Cosmetics Analysis
2 participants