Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BellaBeat - Capstone Project by Google #456

Merged
merged 13 commits into from
Jan 2, 2024

Conversation

BhardwajArjit
Copy link
Contributor

@BhardwajArjit BhardwajArjit commented Dec 20, 2023

Pull Request for ML-Crate 💡

Issue Title: BellaBeat - Capstone Project by Google

  • Aim of the project : The aim of this project is to create a model which will analyze the Bellabeat project.
  • Name: Arjit Bhardwaj
  • GitHub ID: BhardwajArjit
  • Idenitfy yourself: KWOC Contributor

Closes: #248 (partially)

Describe the add-ons or changes you've made 📃

Till now I have completed the Exploratory Data Analysis and concluded the correlations between various variables.

Type of change ☑️

What sort of change have you made:
Exploratory Data Analysis completed

Example how to mark a checkbox:-

  • My code follows the code style of this project.
    -->
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

No issues so far

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @BhardwajArjit :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Create a README.md file inside the Dataset folder and share the URL of the dataset. No need to upload all the .csv files. Only the URL can help others to understand.
  2. Looks good to me till now. Make sure you complete the whole project within the deadline of the event.

@abhisheks008 abhisheks008 added the Requested Changes ⚙️ Some changes have been requested in this PR. label Dec 22, 2023
@BhardwajArjit
Copy link
Contributor Author

Hi @abhisheks008, I have updated the pull request as per the changes requested. Kindly review it.
Definitely, I'll complete this project before 9th January 2024.
Kindly consider this PR for the mid evals.

@BhardwajArjit
Copy link
Contributor Author

BhardwajArjit commented Dec 23, 2023 via email

@abhisheks008
Copy link
Owner

Looks good to me. Proceed with the models once you are ready to do it. I will not merge this PR as of now, make the whole project and update it here. I have noted your work for the mid evaluations.

@BhardwajArjit
Copy link
Contributor Author

Sure. Thanks a lot.

@BhardwajArjit
Copy link
Contributor Author

Hi @abhisheks008, I have updated the PR with the models. Please review the whole project.

@abhisheks008 abhisheks008 changed the title I have completed the Exploratory Data Analysis. Now I will be proceeding with models to be tested. BellaBeat - Capstone Project by Google Jan 2, 2024
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Your PR is approved and ready to be merged.
@BhardwajArjit

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. KWOC 2023 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jan 2, 2024
@abhisheks008 abhisheks008 merged commit 3999cea into abhisheks008:main Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. KWOC 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BellaBeat - Capstone Project by Google
2 participants