Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundesliga Season Analysis #446 #457

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

Anwar11234
Copy link

Pull Request for ML-Crate 💡

Issue Title: Bundesliga Season Analysis #446

  • Info about the related issue (Aim of the project) : Create a data analysis model based on the statistics given through the dataset.
  • Name: Ahmed Anwar
  • **GitHub ID: **Anwat11234
  • Idenitfy yourself: I'm Ahmed Anwar, a 22 years old engineering student from Egypt, I'm contributing to the repo through KWoC program.

Closes: #446

Describe the add-ons or changes you've made 📃

I have added a new project to the repo which is bundesliga analysis project

Give a clear description of what have you added or modifications made
I modified the repository by adding a new project

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • [] I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @Anwar11234 :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic representation of the project. Really appreciated your efforts for this project. Need some changes in the Images folder, remove the :Zone.identifier files.

@Anwar11234

@abhisheks008 abhisheks008 added the Requested Changes ⚙️ Some changes have been requested in this PR. label Dec 24, 2023
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Your PR is approved and ready to be merged.
@Anwar11234

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. KWOC 2023 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Dec 26, 2023
@abhisheks008 abhisheks008 merged commit 50e920b into abhisheks008:main Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. KWOC 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundesliga Season Analysis
2 participants