Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatalities in the Israeli Palestinian War Analysis #458

Merged
merged 25 commits into from
Dec 26, 2023

Conversation

gourav-pramanik
Copy link
Contributor

@gourav-pramanik gourav-pramanik commented Dec 24, 2023

Pull Request for ML-Crate 💡

Issue Title: Fatalities in the Israeli Palestinian War Analysis

  • Info about the related issue (Aim of the project) : Analysing the fatalities in the Israel-Palestine War using python libraries.
  • Name: Gourav Pramanik
  • GitHub ID: gourav-pramanik
  • Idenitfy yourself: KWOC Contributor

Closes: #442

Describe the add-ons or changes you've made 📃

I have added a new project to the repo called Fatalities in the Israeli Palestinian War Analysis
Give a clear description of what have you added or modifications made
I have modified the repository by adding a new project

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested: Self tested.
Describe how have you verified the changes made: -

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @gourav-pramanik :)

@gourav-pramanik gourav-pramanik marked this pull request as ready for review December 24, 2023 14:48
@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. KWOC 2023 labels Dec 26, 2023
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Your PR is approved and ready to be merged.
@gourav-pramanik

@abhisheks008 abhisheks008 merged commit 4390e62 into abhisheks008:main Dec 26, 2023
@abhisheks008
Copy link
Owner

Please share your email for further communications. You can DM me in Discord.
@gourav-pramanik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. KWOC 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatalities in the Israeli Palestinian War Analysis
2 participants