Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Simpsons Episodes Dataset Analysis #527

Merged
merged 4 commits into from
Jan 16, 2024
Merged

The Simpsons Episodes Dataset Analysis #527

merged 4 commits into from
Jan 16, 2024

Conversation

Bayyana-kiran
Copy link
Contributor

@Bayyana-kiran Bayyana-kiran commented Jan 15, 2024 •
edited
Loading

Pull Request for ML-Crate 💡

Issue Title: The Simpsons Episodes Dataset Analysis #465

  • Info about the related issue (Aim of the project): Analysis of The Simpsons Episodes Dataset
  • Name: Sai Kiran B L S
  • GitHub ID: Bayyana-kiran
  • Identify yourself: IWOC2024

Closes: #465

Describe the add-ons or changes you've made 📃

I have added a comprehensive analysis of The Simpsons Episodes Dataset, covering characters, episodes, locations, and script lines. The analysis includes visualizations, character dynamics, episode trends, and sentiment patterns.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

I have tested the analysis by running the Python code on the provided dataset. Additionally, I have verified the visualizations and cross-checked the results with expected outcomes.

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

@github-actions GitHub Actions
Copy link

Our team will soon review your PR. Thanks @Bayyana-kiran :)

@Bayyana-kiran
Copy link
Contributor Author

@abhisheks008 Kindly check

@abhisheks008 abhisheks008 changed the title ADDED #465 The Simpsons Episodes Dataset Analysis Jan 16, 2024
abhisheks008
abhisheks008 requested changes Jan 16, 2024
View reviewed changes
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes.
@Bayyana-kiran

Simpsons Episodes Analysis/Readme.md Outdated
![Sentiment Analyis over time](https://github.com/Bayyana-kiran/sdf/assets/99533113/c4390f94-6e7a-4871-a230-c477f6ac9e6c)


## Conclusion
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the Conclusion, to the point and brief, use bullet points.

@abhisheks008 abhisheks008 added the Requested Changes ⚙️ Some changes have been requested in this PR. label Jan 16, 2024
@Bayyana-kiran
Copy link
Contributor Author

@abhisheks008 KINDLY CHECK

abhisheks008
abhisheks008 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
@Bayyana-kiran

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Beginner 20 points : SSOC 2024 JWOC This issue/pull request will be considered for JWOC 2k22. IWOC2024 IWOC 2.0 Open Source Event and removed Requested Changes ⚙️ Some changes have been requested in this PR. JWOC This issue/pull request will be considered for JWOC 2k22. labels Jan 16, 2024
@abhisheks008 abhisheks008 merged commit fbe1e94 into abhisheks008:main Jan 16, 2024
@abhisheks008
Copy link
Owner

Please share your email ID for further communications.
@Bayyana-kiran

@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Jan 16, 2024
@Bayyana-kiran
Copy link
Contributor Author

Email:bayyanakiran@gmail.com
GitHub: bayyana-kiran

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhisheks008 abhisheks008 abhisheks008 approved these changes

Assignees

@Bayyana-kiran Bayyana-kiran

Labels
Approved ✅ This PR is approved by the PR or, Mentors. Beginner 20 points : SSOC 2024 IWOC2024 IWOC 2.0 Open Source Event Points Added 🎉 This issue's points has been added to the leaderboard.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Simpsons Episodes Dataset Analysis
2 participants
@Bayyana-kiran @abhisheks008