Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank Negara Indonesia Stock Analysis #528

Closed
wants to merge 10 commits into from
Closed

Conversation

pawaspy
Copy link
Contributor

@pawaspy pawaspy commented Jan 16, 2024

Pull Request for ML-Crate 💡

Issue Title:

  • Info about the related issue (Aim of the project) :
  • Name:
  • GitHub ID:
  • Idenitfy yourself:

Closes: #501

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made
I have added the dataset, images, models folder with all files.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @pawaspy :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added two folders. Remove the duplicate one.
@pawaspy

@abhisheks008 abhisheks008 added the Requested Changes ⚙️ Some changes have been requested in this PR. label Jan 16, 2024
@abhisheks008 abhisheks008 changed the title Stock Bank Negara Indonesia Stock Analysis Jan 16, 2024
@abhisheks008
Copy link
Owner

Project folder name should be same as the issue name, Bank Negara Indonesia Stock Analysis

@pawaspy pawaspy closed this Jan 16, 2024
@pawaspy pawaspy deleted the Stock branch January 16, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Requested Changes ⚙️ Some changes have been requested in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bank Negara Indonesia Stock Analysis
2 participants