Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerable Cancer Patients #536

Merged
merged 18 commits into from
Jan 19, 2024
Merged

Conversation

CoderOMaster
Copy link
Contributor

Pull Request for ML-Crate 💡

Issue Title: Issue No 498

  • Info about the related issue (Aim of the project) :
  • Name: Keshav Arora
  • GitHub ID: CoderOMaster
  • Idenitfy yourself: JWOC 2024
    Please Mark this as hard:)

Copy link

Our team will soon review your PR. Thanks @CoderOMaster :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not every issue will mark as Hard, if it goes like this every issue should be of Hard category then.

  • Project folder name should be same as the issue name with no underscore.
  • Put some EDA before going in to the models. Such as Predicted datapoints plot, intensity distribution plot etc.
  • Make the README a bit attractive.

@CoderOMaster

@abhisheks008 abhisheks008 added the Requested Changes ⚙️ Some changes have been requested in this PR. label Jan 18, 2024
@abhisheks008 abhisheks008 linked an issue Jan 18, 2024 that may be closed by this pull request
@CoderOMaster
Copy link
Contributor Author

I understand sir.
I will try my best to implement these

@CoderOMaster
Copy link
Contributor Author

@abhisheks008
Please check i have done the necessary changes now

| Neural Network | 0.67 |
| Logistic Regression| 0.71 |

**NOTE: No graphs were plotted**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have plotted graphs. Remove this and add Visualization heading under that put the graph of intensity distribution. After that Models Applied will come.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly am I supposed to do? I don't get it please

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have written no graphs were plotted that's why I told you to remove that line and make the changes accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done this too..Please merge it


**ROBERTA MODEL IN TENSORFLOW AND PYTORCH WERE PARTIALLY TRAINED DUE TO RESOURCE LIMITATIONS; RESULTS FROM 3 EPOCHS WILL BE PROVIDED**

**IMAGE**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is creating some styling problem, put <br> over here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed that paragraph since it was obvious in the code that I took 3 epochs

![Alt Text](./Images/confusion_matrix.png)

![Alt Text](./Images/intensity.png)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Conclusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conclusion as in?
I have the result plotted

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After finishing a project don't you do some conclusion, this this things we can conclude or just left the project without putting any conclusion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 JWOC This issue/pull request will be considered for JWOC 2k22. and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jan 19, 2024
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
@CoderOMaster

@abhisheks008 abhisheks008 merged commit 0840e13 into abhisheks008:main Jan 19, 2024
@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Jan 19, 2024
@CoderOMaster
Copy link
Contributor Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 JWOC This issue/pull request will be considered for JWOC 2k22. Points Added 🎉 This issue's points has been added to the leaderboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerable Cancer Patients Analysis and Prediction
2 participants