Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassava Leaf Disease Classification #547

Merged
merged 11 commits into from
Jan 25, 2024
Merged

Conversation

CoderOMaster
Copy link
Contributor

Pull Request for ML-Crate 💡

Issue Title:

  • Info about the related issue (Aim of the project) :
  • Name: Keshav Arora
  • GitHub ID: CoderOMaster
  • Idenitfy yourself: JWOC Mentee

Closes: #issue number that will be closed through this PR 506

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @CoderOMaster :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Update the Link.txt file name as README.md.
  2. Try to do some EDA with the dataset, before implementing the models. Also add the EDA results in the README.md under the Visualization tag.

@CoderOMaster

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the needful changes.

@abhisheks008 abhisheks008 added the Requested Changes ⚙️ Some changes have been requested in this PR. label Jan 24, 2024
@CoderOMaster
Copy link
Contributor Author

@abhisheks008 I hv already linked kaggle database in readme file though.Should I rename link.txt anyways?

@abhisheks008
Copy link
Owner

@abhisheks008 I hv already linked kaggle database in readme file though.Should I rename link.txt anyways?

Yes

@CoderOMaster
Copy link
Contributor Author

@abhisheks008 I have done all changes required.Please assign appropriate difficulty as per our previous discussion and approve the merge request.
Thank You

@abhisheks008 abhisheks008 linked an issue Jan 25, 2024 that may be closed by this pull request
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
@CoderOMaster

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Advanced Points 40 - SSOC 2024 JWOC This issue/pull request will be considered for JWOC 2k22. and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jan 25, 2024
@abhisheks008 abhisheks008 merged commit ed4e2db into abhisheks008:main Jan 25, 2024
@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Advanced Points 40 - SSOC 2024 Approved ✅ This PR is approved by the PR or, Mentors. JWOC This issue/pull request will be considered for JWOC 2k22. Points Added 🎉 This issue's points has been added to the leaderboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cassava Leaf Disease Classification
2 participants