Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F1 Visa Experiences #569

Closed
wants to merge 24 commits into from
Closed

F1 Visa Experiences #569

wants to merge 24 commits into from

Conversation

stackaway
Copy link
Contributor

@stackaway stackaway commented Feb 9, 2024

Pull Request for ML-Crate 💡

Issue Title:

  • Info about the related issue (Aim of the project) : Finding out if the review is positive, negative or neutral.
  • Name: Churnika S Mundas
  • GitHub ID: stackaway
  • Idenitfy yourself: JWOC'24 Contributor

Closes: #128

Describe the add-ons or changes you've made 📃

Preprocessed the dataset that is given and proceeded to using Logistic Regression, Random Forest Classifier and SVM models and SVM had the highest accuracy followed by Random Forest Classifier.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Changes have been tested by plotting graphs and seeing the level of accuracy attained on validation dataset using various models.

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

github-actions bot commented Feb 9, 2024

Our team will soon review your PR. Thanks @stackaway :)

@stackaway
Copy link
Contributor Author

@abhisheks008 please review this pr and requested to merge it under JWOC'24

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the .DS_Store file.
@stackaway

@abhisheks008 abhisheks008 added the Requested Changes ⚙️ Some changes have been requested in this PR. label Feb 10, 2024
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.DS_Store is still there.

@stackaway
Copy link
Contributor Author

there were 2 .DS_Store files, I was able to delete one, the other I am unable to figure out how to delete. @abhisheks008 can you pls help me out with how I can proceed

@abhisheks008
Copy link
Owner

there were 2 .DS_Store files, I was able to delete one, the other I am unable to figure out how to delete. @abhisheks008 can you pls help me out with how I can proceed

Can you make a fresh PR for this project after deleting the files from your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Requested Changes ⚙️ Some changes have been requested in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F1 Visa Experiences
2 participants