Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Addition]: Web App for Vehicle Live Risk Prediction #629

Merged
merged 18 commits into from
Jun 11, 2024

Conversation

shivansh-2003
Copy link
Contributor

Pull Request for ML-Crate 💡

Issue Title:[Feature Addition]: Web App for Vehicle Live Risk Prediction #602

  • Info about the related issue (Aim of the project) : 'The aim is to create a web app for the Vehicle Live Risk Prediction project.
  • Name: Shivansh Mahajan
  • GitHub ID: https://github.com/shivansh-2003
  • Idenitfy yourself: Data Scientist

Closes: #issue number that will be closed through this PR

Describe the add-ons or changes you've made 📃

  1. I have updated xgboost.py file
  2. I have created Web app directory
  3. I have created app.py and readme.md
  4. I have also created pickle file in model folder and Readme.md file
  5. I have updated README.md
  6. I also created REadme.md file in dataset folder

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • [☑️] New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
I have tested the vehicle live risk prediction app by running the app on Streamlit and verifying the result by testing various inputs .

Checklist: ☑️

  • [☑️] My code follows the guidelines of this project.
  • [☑️ ] I have performed a self-review of my own code.
  • [☑️] I have commented my code, particularly wherever it was hard to understand.
  • [☑️] I have made corresponding changes to the documentation.
  • [☑️] My changes generate no new warnings.
  • [☑️] I have added things that prove my fix is effective or that my feature works.
  • [☑️] Any dependent changes have been merged and published in downstream modules.

Copy link

github-actions bot commented Jun 5, 2024

Our team will soon review your PR. Thanks @shivansh-2003 :)

@abhisheks008 abhisheks008 changed the title Pull request for ML-Crate [Feature Addition]: Web App for Vehicle Live Risk Prediction Jun 5, 2024
@abhisheks008
Copy link
Owner

Create a single file for the models implemented, do not use so many files for every models you have implemented.
@shivansh-2003

@abhisheks008 abhisheks008 added Requested Changes ⚙️ Some changes have been requested in this PR. SSOC labels Jun 5, 2024
@shivansh-2003
Copy link
Contributor Author

sir i have deleted the extra models file and only kept xgboost file and if any other changes required please let me know

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you added a new jupyter notebook file and did the model creation?
@shivansh-2003

@abhisheks008 abhisheks008 linked an issue Jun 6, 2024 that may be closed by this pull request
@shivansh-2003
Copy link
Contributor Author

shivansh-2003 commented Jun 6, 2024

I have modified the existing xgboost file with visualization and model training and pickle file creation

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove the .DS_Store files.
  2. The file name is README.md. Please update the file name everywhere in the project.
  3. The folder name should be Web App. Also upload the demonstration video file inside the Web App folder.
  4. Why have you removed the .ipynb files. You can keep them, I don't that will effect your contributions.

@shivansh-2003
Copy link
Contributor Author

All the requested changes have been catered . Video demonstration is uploaded in web app folder and link is also provided in readme file . I have restored all the extra model files that i have deleted and renamed all readme file . Deleted .ds/store file.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove the .DS_Store file outside the project folder.

@@ -0,0 +1,31 @@
# Live Vehicle Risk Prediction Dataset

## Overview
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this README file

@@ -0,0 +1,94 @@
# Live Vehicle Risk Detection using XGBoost Model

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this file as README.md

- Provides information about the model explanation and purpose of the application.

### Video Demonstration 🎥
[Watch the video](https://vimeo.com/953208773?share=copy)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hyperlinking the demo video in the README, copy and paste the same video to the README from your local system directly, it'll work better as we can get an embedded version of the video.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sir i am trying to embed video from my local system but it does not work by copying directly

@shivansh-2003
Copy link
Contributor Author

I have completed all issues except of video embed feature because a/q to your instruction embed is not created by copying local file video

@abhisheks008
Copy link
Owner

I have completed all issues except of video embed feature because a/q to your instruction embed is not created by copying local file video

Just drag and drop the video file from your local system to the README while editing it.

@shivansh-2003
Copy link
Contributor Author

Just drag and drop the video file from your local system to the README while editing it.
Done sir

@shivansh-2003
Copy link
Contributor Author

sir i have completed all the requested task

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved @shivansh-2003

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Advanced Points 40 - SSOC 2024 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jun 11, 2024
@abhisheks008 abhisheks008 merged commit b5112ea into abhisheks008:main Jun 11, 2024
@abhisheks008
Copy link
Owner

Please share your email address for further communication.
@shivansh-2003

@abhisheks008
Copy link
Owner

Please share your email address for further communication. @shivansh-2003

Share it ASAP.

@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Jun 15, 2024
@shivansh-2003
Copy link
Contributor Author

shivansh.m2003@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Advanced Points 40 - SSOC 2024 Approved ✅ This PR is approved by the PR or, Mentors. Points Added 🎉 This issue's points has been added to the leaderboard. SSOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Addition]: Web App for Vehicle Live Risk Prediction
2 participants