-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Addition]: Web App for Vehicle Live Risk Prediction #629
Conversation
Our team will soon review your PR. Thanks @shivansh-2003 :) |
Create a single file for the models implemented, do not use so many files for every models you have implemented. |
sir i have deleted the extra models file and only kept xgboost file and if any other changes required please let me know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you added a new jupyter notebook file and did the model creation?
@shivansh-2003
I have modified the existing xgboost file with visualization and model training and pickle file creation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove the
.DS_Store
files. - The file name is
README.md
. Please update the file name everywhere in the project. - The folder name should be
Web App
. Also upload the demonstration video file inside the Web App folder. - Why have you removed the
.ipynb
files. You can keep them, I don't that will effect your contributions.
All the requested changes have been catered . Video demonstration is uploaded in web app folder and link is also provided in readme file . I have restored all the extra model files that i have deleted and renamed all readme file . Deleted .ds/store file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also remove the .DS_Store
file outside the project folder.
@@ -0,0 +1,31 @@ | |||
# Live Vehicle Risk Prediction Dataset | |||
|
|||
## Overview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename this README file
@@ -0,0 +1,94 @@ | |||
# Live Vehicle Risk Detection using XGBoost Model | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename this file as README.md
- Provides information about the model explanation and purpose of the application. | ||
|
||
### Video Demonstration 🎥 | ||
[Watch the video](https://vimeo.com/953208773?share=copy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of hyperlinking the demo video in the README, copy and paste the same video to the README from your local system directly, it'll work better as we can get an embedded version of the video.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sir i am trying to embed video from my local system but it does not work by copying directly
I have completed all issues except of video embed feature because a/q to your instruction embed is not created by copying local file video |
Just drag and drop the video file from your local system to the README while editing it. |
|
sir i have completed all the requested task |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved @shivansh-2003
Please share your email address for further communication. |
Share it ASAP. |
Pull Request for ML-Crate 💡
Issue Title:[Feature Addition]: Web App for Vehicle Live Risk Prediction #602
Closes: #issue number that will be closed through this PR
Describe the add-ons or changes you've made 📃
Give a clear description of what have you added or modifications made
Type of change ☑️
What sort of change have you made:
How Has This Been Tested? ⚙️
Describe how it has been tested
I have tested the vehicle live risk prediction app by running the app on Streamlit and verifying the result by testing various inputs .
Checklist: ☑️