Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pcos Detection #635

Merged
merged 13 commits into from
Jun 19, 2024
Merged

Pcos Detection #635

merged 13 commits into from
Jun 19, 2024

Conversation

payalsinha12
Copy link
Contributor

@payalsinha12 payalsinha12 commented Jun 6, 2024

Pull Request for ML-Crate 💡

Issue Title: [PROJECT ADDITION]- PCOS DETECTION

  • Info about the related issue (Pcos Detection ) : helps to detect that the person is suffering from Pcos or not.
  • Name: Payal SInha
  • GitHub ID: https://github.com/payalsinha12
  • Idenitfy yourself: A Web Developer and Graphic Designer

Closes: #624

Describe the add-ons or changes you've made 📃

I made a project on Pcos Detection using the dataset taken from Kaggle.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

github-actions bot commented Jun 6, 2024

Our team will soon review your PR. Thanks @payalsinha12 :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the project structure and update your files accordingly.
@payalsinha12

@abhisheks008 abhisheks008 added Requested Changes ⚙️ Some changes have been requested in this PR. SSOC labels Jun 6, 2024
@payalsinha12
Copy link
Contributor Author

what changes ?? @abhisheks008

@abhisheks008
Copy link
Owner

https://github.com/abhisheks008/ML-Crate/tree/main/ASELSAN%20Stock%20Prices

Follow the project structure and put your files.

Copy link
Contributor Author

@payalsinha12 payalsinha12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes done.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove the Pcos Detection.ipynb file, which is outside the project folder.
  2. File names should be as README.md, requirements.txt.
  3. Update the README file as per the given template, https://github.com/abhisheks008/ML-Crate/blob/main/.github/readme_template.md. Make it eye pleasing as it's shown in the template, using different emojis.
  4. Remove the .csv file from the Model folder. as you have already shared the dataset file inside the Dataset folder.
  5. Upload the EDA results inside the Images folder including the confusion matrices, accuracy graphs.
  6. Add different visualization images inside the README file and showcase different aspects of the dataset.

@payalsinha12

Copy link
Contributor Author

@payalsinha12 payalsinha12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes done

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove the images from the Model folder and put them inside the Images folder.
  2. Remove the desktop.ini file.

@payalsinha12
Copy link
Contributor Author

you told me to add different visualization images inside the README file. the images present inside the model folder is actually present in the README file now you are asking to delete the pictures what should i do ?? and i removed the desktop.ini file @abhisheks008

Copy link
Contributor Author

@payalsinha12 payalsinha12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@abhisheks008
Copy link
Owner

you told me to add different visualization images inside the README file. the images present inside the model folder is actually present in the README file now you are asking to delete the pictures what should i do ?? and i removed the desktop.ini file @abhisheks008

If you remove the images from the Model folder and put them inside the Images folder, you can still hyperlink the images and use them inside the README irrespective of the folder.

Copy link
Contributor Author

@payalsinha12 payalsinha12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hyperlink added @abhisheks008

@payalsinha12
Copy link
Contributor Author

@abhisheks008 hey please review this

@abhisheks008
Copy link
Owner

image

You haven't fixed this.

@payalsinha12
Copy link
Contributor Author

@abhisheks008 what is the mistake please elaborate

@abhisheks008
Copy link
Owner

image You haven't fixed this.

Create a table for showing the accuracy scores, it's not feasible to show the accuracy scores like this. It's a minor markdown change you need to do.

@payalsinha12
Copy link
Contributor Author

please tell in which folder i have to create the table suggest the proper path for it @abhisheks008

<a href="C:\Users\KIIT\Desktop\SSOC'24\ML-Crate\Pcos Detection\Images\Screenshot 2024-06-07 114118.png">Class Dostribution using SMOTE</a>


📈 **Performance of the Models based on the Accuracy Scores**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markdown script you have written is not creating a table, instead it is showing one after another.

This is what you need to fix.

Copy link
Contributor Author

@payalsinha12 payalsinha12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check now @abhisheks008

@payalsinha12
Copy link
Contributor Author

@abhisheks008 please review it and merge it

@abhisheks008
Copy link
Owner

image

Images are not visible.

Copy link
Contributor Author

@payalsinha12 payalsinha12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the changes are done successfully . I've uploaded the drive link and it is working now @abhisheks008

@payalsinha12
Copy link
Contributor Author

please review it asap @abhisheks008

@abhisheks008
Copy link
Owner

No need to add drive link. You can just hyperlink the images from the Images folder to the README.

@payalsinha12
Copy link
Contributor Author

payalsinha12 commented Jun 16, 2024

but what is the need of changing again if that link is working ultimately we want to see the pictures and it is visible then why i have to change it . please assign me as those links are also working now @abhisheks008

Copy link
Contributor Author

@payalsinha12 payalsinha12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have done the changes now please review it and merge it @abhisheks008

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved @payalsinha12

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jun 19, 2024
@abhisheks008 abhisheks008 merged commit 81a1bda into abhisheks008:main Jun 19, 2024
@abhisheks008
Copy link
Owner

Hi @payalsinha12 sorry for the inconvenience caused from my end. Please share your email address for further communications.

I have added your points in the excel sheet, no worries now.

@payalsinha12
Copy link
Contributor Author

Hi @payalsinha12 sorry for the inconvenience caused from my end. Please share your email address for further communications.

I have added your points in the excel sheet, no worries now.

sinhapayal2913@gmail.com
Thank you for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 SSOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PROJECT ADDITION]- PCOS DETECTION
2 participants