-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pcos Detection #635
Pcos Detection #635
Conversation
Our team will soon review your PR. Thanks @payalsinha12 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow the project structure and update your files accordingly.
@payalsinha12
what changes ?? @abhisheks008 |
https://github.com/abhisheks008/ML-Crate/tree/main/ASELSAN%20Stock%20Prices Follow the project structure and put your files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove the
Pcos Detection.ipynb
file, which is outside the project folder. - File names should be as
README.md
,requirements.txt
. - Update the README file as per the given template, https://github.com/abhisheks008/ML-Crate/blob/main/.github/readme_template.md. Make it eye pleasing as it's shown in the template, using different emojis.
- Remove the
.csv
file from the Model folder. as you have already shared the dataset file inside the Dataset folder. - Upload the EDA results inside the Images folder including the confusion matrices, accuracy graphs.
- Add different visualization images inside the README file and showcase different aspects of the dataset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove the images from the Model folder and put them inside the Images folder.
- Remove the
desktop.ini
file.
you told me to add different visualization images inside the README file. the images present inside the model folder is actually present in the README file now you are asking to delete the pictures what should i do ?? and i removed the desktop.ini file @abhisheks008 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
If you remove the images from the Model folder and put them inside the Images folder, you can still hyperlink the images and use them inside the README irrespective of the folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hyperlink added @abhisheks008
@abhisheks008 hey please review this |
@abhisheks008 what is the mistake please elaborate |
please tell in which folder i have to create the table suggest the proper path for it @abhisheks008 |
Pcos Detection/Model/README.md
Outdated
<a href="C:\Users\KIIT\Desktop\SSOC'24\ML-Crate\Pcos Detection\Images\Screenshot 2024-06-07 114118.png">Class Dostribution using SMOTE</a> | ||
|
||
|
||
📈 **Performance of the Models based on the Accuracy Scores** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown script you have written is not creating a table, instead it is showing one after another.
This is what you need to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check now @abhisheks008
@abhisheks008 please review it and merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all the changes are done successfully . I've uploaded the drive link and it is working now @abhisheks008
please review it asap @abhisheks008 |
No need to add drive link. You can just hyperlink the images from the Images folder to the README. |
but what is the need of changing again if that link is working ultimately we want to see the pictures and it is visible then why i have to change it . please assign me as those links are also working now @abhisheks008 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have done the changes now please review it and merge it @abhisheks008
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved @payalsinha12
Hi @payalsinha12 sorry for the inconvenience caused from my end. Please share your email address for further communications. I have added your points in the excel sheet, no worries now. |
sinhapayal2913@gmail.com |
Pull Request for ML-Crate 💡
Issue Title: [PROJECT ADDITION]- PCOS DETECTION
Closes: #624
Describe the add-ons or changes you've made 📃
I made a project on Pcos Detection using the dataset taken from Kaggle.
Type of change ☑️
What sort of change have you made:
How Has This Been Tested? ⚙️
Describe how it has been tested
Describe how have you verified the changes made
Checklist: ☑️