-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sensor fault detection #657
Conversation
Our team will soon review your PR. Thanks @daemonX10 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the project structure and make the changes accordingly.
@daemonX10
@abhisheks008 changes done . i have make new folder for web part and remaining dataset , model and notebook along with image in main folder |
In the web app folder create a README file (template: https://github.com/abhisheks008/ML-Crate/blob/main/.github/web-app-readme-template.md) and put a demonstration video of the working of the web app. Also attach the same video in the README so that others can view that easily. |
@abhisheks008 done those change in web readme file |
Just copy the demo video from your local system and paste the same inside the README so that it can be embedded inside the README and can also be viewed easily. |
that video is available in img folder already @abhisheks008 |
Although it is available in the img folder, we can not view that video directly. That's why I told you to do so in the above comment. |
@abhisheks008 added direct video embedding in readme |
Video is not visible. @daemonX10 |
i have 4 things to ask...
|
@daemonX10 will explain this very well, as he is the one who is developing the whole thing. About the web app part, it is hosted in local. As a beginner when you are building a college project, locally hosted web app is enough, because majority of the college students used to take help from this project repository. |
Local deployed, i have deployed multiple projects on render, you could ask me, although i have added all steps in Readme and the reason i don't deployed it, cause i not that much complex project. |
|
@daemonX10 to upload a video.. first go to any code issue tab.. in there from your local upload the video in chatbox...then github will provide a link..paste that in your readme note... to check if your work or not.. go to file changed... in that .. go the the desired file... and click on 3 dots in right cornor of that particular...then view file...and then you can see what is visible to public also... when used xgboost well..there is no issue in using decision tree..but it's no use when using xgboost...as it is the upgraded version of that |
Upload the video as mentioned @daemonX10 |
sensor.video.mp4"https://github.com/abhisheks008/ML-Crate/assets/115637298/7712a38e-94b3-4463-ba65-c34f3e3a484d" |
Do check now @abhisheks008, it showing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @daemonX10 looks good to me. Approved ✅
Hi @daemonX10 have you registered in the OSLead portal? |
What is OSLead? @abhisheks008 |
You are part of SSOC and you don't know OSLead? Check out the announcement channel of the SSOC Discord server and register yourself in OSLead for leader board. |
Hi @daemonX10 have you done the needful? |
I'm forgot that, can you give me link please @abhisheks008 |
Pull Request for ML-Crate 💡
Issue Title: End-to-end Sensor Fault Detection #644
Closes: #644
Describe the add-ons or changes you've made 📃\
What sort of change have you made:
How Has This Been Tested? ⚙️
Describe how it has been tested
Describe how have you verified the changes made
Checklist: ☑️