Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mineral classification #668

Merged
merged 12 commits into from
Jun 23, 2024
Merged

Mineral classification #668

merged 12 commits into from
Jun 23, 2024

Conversation

tanuj437
Copy link
Contributor

Pull Request for ML-Crate 💡

Issue Title: Mineral Classification

  • Info about the related issue (Aim of the project) : To Classify the mineral photo
  • Name: Tanuj Saxena
  • Email ID for further communication: tanuj.saxena.rks@gmail.com
  • GitHub ID: tanuj437
  • Idenitfy yourself: SSOC'24 Contributor

Closes: #467 number that will be closed through this PR

Describe the add-ons or changes you've made 📃

I've included a full README.md file in the mineral classification project's folder. This README.md file contains thorough descriptions and visual representations of numerous analyses and model outputs for the mineral classification problem. It contains explanations and graphics for label distribution methods such as count distribution, and model performance outputs (SVM, Random Forest, K-NN, CNN, Logistic Regression, Decision Tree Classification, Extra Tree Classification). These additions are intended to improve the clarity and understanding of the project's visual and analytical components.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

I have tested it on webapp with the same images of mineral which we have trained the model.
Since i tested which all types of minerals photos and it accurately predict the mineral for each input image

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @tanuj437 :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce the number of images files in the Images folder, put at least one file there for each of the minerals.

@abhisheks008 abhisheks008 added Requested Changes ⚙️ Some changes have been requested in this PR. SSOC labels Jun 19, 2024
@tanuj437
Copy link
Contributor Author

tanuj437 commented Jun 19, 2024

@abhisheks008 Reduced the number of images in image folder as well as put the each mineral photo in it too. Can't reduce more images in there

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images you have stored in the img folder are the datapoints right? And these same images can be restored from the dataset URL.

Correct me if I am wrong.

@tanuj437
Copy link
Contributor Author

tanuj437 commented Jun 20, 2024

@abhisheks008 yes those are the datapoints which trained the model...img folder in Dataset is actually the dataset folder

So do i put just one image for each mineral of that folder as well?

@abhisheks008
Copy link
Owner

@abhisheks008 yes those are the datapoints which trained the model...img folder in Dataset is actually the dataset folder

So do i put just one image for each mineral of that folder as well?

If you are sharing the dataset URL in the Dataset/README file then no need to add the datapoints (images). This will reduce the space occupancy of the project folder.

@tanuj437
Copy link
Contributor Author

@abhisheks008 All changes Done

@abhisheks008
Copy link
Owner

Upload a demonstration video of the working of the web app and attach the same in the Web App/README, so that others can have an idea about the working of the web app.

@tanuj437
Copy link
Contributor Author

@abhisheks008 Done added

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approved @tanuj437

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Advanced Points 40 - SSOC 2024 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jun 23, 2024
@abhisheks008 abhisheks008 merged commit 9448bdc into abhisheks008:main Jun 23, 2024
@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Advanced Points 40 - SSOC 2024 Approved ✅ This PR is approved by the PR or, Mentors. Points Added 🎉 This issue's points has been added to the leaderboard. SSOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mineral Classification
2 participants