Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecommerce trends Analysis #676

Merged
merged 11 commits into from
Jun 23, 2024
Merged

Conversation

adi271001
Copy link
Contributor

@adi271001 adi271001 commented Jun 21, 2024

Pull Request for ML-Crate 💡

Issue Title: #652

Closes: #issue number that will be closed through this PR #652

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made
Added folders containing models , images , results , requirements.txt

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
divided dataset into test and train , evaluated for test set

Describe how have you verified the changes made
i have verified the model for overfitting and underfitting via graphs

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @adi271001 :)

@abhisheks008 abhisheks008 linked an issue Jun 23, 2024 that may be closed by this pull request
@abhisheks008
Copy link
Owner

While writing the Conclusion use bullet points, otherwise it's not looking that much eye-pleasing.

@abhisheks008 abhisheks008 added Requested Changes ⚙️ Some changes have been requested in this PR. VSoC’24 Vinyasa Summer of Code (VSOC) labels Jun 23, 2024
@adi271001
Copy link
Contributor Author

@abhisheks008 done please do check

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved @adi271001

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. MEDIUM VSOC - 10 Points and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jun 23, 2024
@abhisheks008 abhisheks008 merged commit 2f6cbd5 into abhisheks008:main Jun 23, 2024
@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Jun 23, 2024
@abhisheks008
Copy link
Owner

While assigning your points in the VSOC, you email is not found there. @adi271001

@abhisheks008
Copy link
Owner

While assigning your points in the VSOC, you email is not found there. @adi271001

Add your details in the Contributor-list channel in the VSOC server, otherwise your points will not going to be calculated from their end.

@adi271001
Copy link
Contributor Author

@abhisheks008 i have added the details in contributor list please inform me once points are added

@abhisheks008
Copy link
Owner

@abhisheks008 i have added the details in contributor list please inform me once points are added

Added your points with respect to your email ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. MEDIUM VSOC - 10 Points Points Added 🎉 This issue's points has been added to the leaderboard. VSoC’24 Vinyasa Summer of Code (VSOC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E-commerce Trends Analysis
2 participants